From 88da39f667785ba9fd45a67e4012337672de92d2 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 2 Mar 2018 11:10:12 -0500 Subject: [PATCH] Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! --- misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl index 5826526..9226299 100755 --- a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl +++ b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl @@ -57,6 +57,7 @@ my @holds_waiting_days_to_call; my $library_code; my $help; my $outfile; +my $skip_patrons_with_email; # maps to convert I-tiva terms to Koha terms my $type_module_map = { @@ -78,6 +79,7 @@ GetOptions( 'type:s' => \@types, 'w|waiting-hold-day:s' => \@holds_waiting_days_to_call, 'c|code|library-code:s' => \$library_code, + 's|skip-patrons-with-email' => \$skip_patrons_with_email, 'help|h' => \$help, ); @@ -116,7 +118,11 @@ foreach my $type (@types) { next; } + my $patrons; foreach my $issues (@loop) { + $patrons->{$issues->{borrowernumber}} ||= Koha::Patrons->find( $issues->{borrowernumber} ) if $skip_patrons_with_email; + next if $skip_patrons_with_email && $patrons->{$issues->{borrowernumber}}->notice_email_address; + my $date_dt = dt_from_string ( $issues->{'date_due'} ); my $due_date = output_pref( { dt => $date_dt, dateonly => 1, dateformat =>'metric' } ); -- 2.10.2