From c27b59dba1543c8fc9ef20ea729f18fffa65d43c Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Sun, 7 Jan 2018 14:06:14 -0300
Subject: [PATCH] Bug 19933: Remove patronflags - unused vars
oldamount/amountold in circulation.pl
There is oldamound/amountold variable that is sent to the template but
never used later. Let remove it now to avoid useless replacement.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
---
circ/circulation.pl | 4 ----
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 1 -
2 files changed, 5 deletions(-)
diff --git a/circ/circulation.pl b/circ/circulation.pl
index 93ed09c..125d75d 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -552,9 +552,6 @@ foreach my $flag ( sort keys %$flags ) {
}
}
-my $amountold = $flags ? $flags->{'CHARGES'}->{'message'} || 0 : 0;
-$amountold =~ s/^.*\$//; # remove upto the $, if any
-
my $total = $patron ? $patron->account->balance : 0;
if ( $patron && $patron->is_child) {
@@ -632,7 +629,6 @@ $template->param(
borrowernumber => $borrowernumber,
branch => $branch,
was_renewed => scalar $query->param('was_renewed') ? 1 : 0,
- amountold => $amountold,
barcodes => $barcodes,
stickyduedate => $stickyduedate,
duedatespec => $duedatespec,
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
index 4c66feb..2f1d118 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ -603,7 +603,6 @@ No patron matched <span class="ex">[% message | html %]</span>
<input type="hidden" name="debt_confirmed" value="[% debt_confirmed %]" />
[% IF ( CHARGES ) %]
<input type="hidden" name="charges" value="yes" />
- <input type="hidden" name="oldamount" value="[% amountold %]" />
[% END %]
</fieldset>
[% IF ( issue ) %]
--
2.1.4