View | Details | Raw Unified | Return to bug 15516
Collapse All | Expand All

(-)a/C4/Reserves.pm (-32 / +32 lines)
Lines 139-147 BEGIN { Link Here
139
139
140
        GetMaxPatronHoldsForRecord
140
        GetMaxPatronHoldsForRecord
141
141
142
        &AddReserveGroup
142
        &AddHoldGroup
143
        &DeleteReserveGroup
143
        &DeleteHoldGroup
144
        &GetReserveGroupReserves
144
        &GetHoldGroupHolds
145
    );
145
    );
146
    @EXPORT_OK = qw( MergeHolds );
146
    @EXPORT_OK = qw( MergeHolds );
147
}
147
}
Lines 168-174 sub AddReserve { Link Here
168
        $branch,   $borrowernumber, $biblionumber, $bibitems,
168
        $branch,   $borrowernumber, $biblionumber, $bibitems,
169
        $priority, $resdate,        $expdate,      $notes,
169
        $priority, $resdate,        $expdate,      $notes,
170
        $title,    $checkitem,      $found,        $itemtype,
170
        $title,    $checkitem,      $found,        $itemtype,
171
        $reserve_group_id
171
        $hold_group_id
172
    ) = @_;
172
    ) = @_;
173
173
174
    $resdate = output_pref( { str => dt_from_string( $resdate ), dateonly => 1, dateformat => 'iso' })
174
    $resdate = output_pref( { str => dt_from_string( $resdate ), dateonly => 1, dateformat => 'iso' })
Lines 206-212 sub AddReserve { Link Here
206
            waitingdate    => $waitingdate,
206
            waitingdate    => $waitingdate,
207
            expirationdate => $expdate,
207
            expirationdate => $expdate,
208
            itemtype       => $itemtype,
208
            itemtype       => $itemtype,
209
            reserve_group_id => $reserve_group_id,
209
            hold_group_id => $hold_group_id,
210
        }
210
        }
211
    )->store();
211
    )->store();
212
212
Lines 475-481 sub GetReserveCount { Link Here
475
        SELECT COUNT(*) AS counter
475
        SELECT COUNT(*) AS counter
476
        FROM reserves
476
        FROM reserves
477
        WHERE borrowernumber = ?
477
        WHERE borrowernumber = ?
478
        AND reserve_group_id is NULL"; #added by 15516
478
        AND hold_group_id is NULL"; #added by 15516
479
    my $sth = $dbh->prepare($query);
479
    my $sth = $dbh->prepare($query);
480
    $sth->execute($borrowernumber);
480
    $sth->execute($borrowernumber);
481
    my $row = $sth->fetchrow_hashref;
481
    my $row = $sth->fetchrow_hashref;
Lines 484-493 sub GetReserveCount { Link Here
484
    $count += $row->{counter};
484
    $count += $row->{counter};
485
485
486
    $query = "
486
    $query = "
487
        SELECT COUNT(DISTINCT reserve_group_id) AS counter
487
        SELECT COUNT(DISTINCT hold_group_id) AS counter
488
        FROM reserves
488
        FROM reserves
489
        WHERE borrowernumber = ?
489
        WHERE borrowernumber = ?
490
        AND reserve_group_id is not NULL
490
        AND hold_group_id is not NULL
491
    ";
491
    ";
492
    $sth = $dbh->prepare($query);
492
    $sth = $dbh->prepare($query);
493
    $sth->execute($borrowernumber);
493
    $sth->execute($borrowernumber);
Lines 1055-1068 sub ModReserveAffect { Link Here
1055
    $hold->itemnumber($itemnumber);
1055
    $hold->itemnumber($itemnumber);
1056
    $hold->set_waiting($transferToDo);
1056
    $hold->set_waiting($transferToDo);
1057
1057
1058
    if ($hold->reserve_group_id) {
1058
    if ($hold->hold_group_id) {
1059
        # Delete other reserves from same group
1059
        # Delete other reserves from same group
1060
        $dbh->do(q{
1060
        $dbh->do(q{
1061
            DELETE FROM reserves
1061
            DELETE FROM reserves
1062
            WHERE reserve_group_id = ?
1062
            WHERE hold_group_id = ?
1063
              AND reserve_id != ?
1063
              AND reserve_id != ?
1064
        }, undef, $hold->reserve_group_id, $hold->reserve_id);
1064
        }, undef, $hold->hold_group_id, $hold->reserve_id);
1065
        DeleteReserveGroup($hold->reserve_group_id);
1065
        DeleteHoldGroup($hold->hold_group_id);
1066
    }
1066
    }
1067
1067
1068
    _koha_notify_reserve( $hold->reserve_id )
1068
    _koha_notify_reserve( $hold->reserve_id )
Lines 2121-2174 sub GetHoldRule { Link Here
2121
    return $sth->fetchrow_hashref();
2121
    return $sth->fetchrow_hashref();
2122
}
2122
}
2123
2123
2124
=head2 AddReserveGroup
2124
=head2 AddHoldGroup
2125
2125
2126
    my $reserve_group_id = AddReserveGroup();
2126
    my $hold_group_id = AddHoldGroup();
2127
2127
2128
Creates a new reserve group and returns its ID
2128
Creates a new hold group and returns its ID
2129
2129
2130
=cut
2130
=cut
2131
2131
2132
sub AddReserveGroup {
2132
sub AddHoldGroup {
2133
    my $dbh = C4::Context->dbh;
2133
    my $dbh = C4::Context->dbh;
2134
2134
2135
    $dbh->do('INSERT INTO reserve_group VALUES ()');
2135
    $dbh->do('INSERT INTO hold_group VALUES ()');
2136
    return $dbh->last_insert_id(undef, undef, 'reserve_group', undef);
2136
    return $dbh->last_insert_id(undef, undef, 'hold_group', undef);
2137
}
2137
}
2138
2138
2139
=head2 DeleteReserveGroup
2139
=head2 DeleteHoldGroup
2140
2140
2141
    DeleteReserveGroup($reserve_group_id);
2141
    DeleteHoldGroup($hold_group_id);
2142
2142
2143
Delete a reserve group. Reserves that belong to this group are not removed.
2143
Delete a hold group. Reserves that belong to this group are not removed.
2144
2144
2145
=cut
2145
=cut
2146
2146
2147
sub DeleteReserveGroup {
2147
sub DeleteHoldGroup {
2148
    my ($reserve_group_id) = @_;
2148
    my ($hold_group_id) = @_;
2149
2149
2150
    my $dbh = C4::Context->dbh;
2150
    my $dbh = C4::Context->dbh;
2151
    my $query = 'DELETE FROM reserve_group WHERE reserve_group_id = ?';
2151
    my $query = 'DELETE FROM hold_group WHERE hold_group_id = ?';
2152
    $dbh->do($query, undef, $reserve_group_id);
2152
    $dbh->do($query, undef, $hold_group_id);
2153
}
2153
}
2154
2154
2155
=head2 GetReserveGroupReserves
2155
=head2 GetHoldGroupHolds
2156
2156
2157
    my @reserves = GetReserveGroupReserves($reserve_group_id);
2157
    my @reserves = GetHoldGroupHolds($hold_group_id);
2158
2158
2159
Fetch all reserve from a reserve group.
2159
Fetch all reserve from a hold group.
2160
2160
2161
=cut
2161
=cut
2162
2162
2163
sub GetReserveGroupReserves {
2163
sub GetHoldGroupHolds {
2164
    my ($reserve_group_id) = @_;
2164
    my ($hold_group_id) = @_;
2165
2165
2166
    my $dbh = C4::Context->dbh;
2166
    my $dbh = C4::Context->dbh;
2167
2167
2168
    my $reserves = $dbh->selectall_arrayref(q{
2168
    my $reserves = $dbh->selectall_arrayref(q{
2169
        SELECT * FROM reserves
2169
        SELECT * FROM reserves
2170
        WHERE reserve_group_id = ?
2170
        WHERE hold_group_id = ?
2171
    }, { Slice => {} }, $reserve_group_id);
2171
    }, { Slice => {} }, $hold_group_id);
2172
2172
2173
    return () unless defined $reserves;
2173
    return () unless defined $reserves;
2174
2174
(-)a/installer/data/mysql/atomicupdate/bug_15516.sql (-8 / +8 lines)
Lines 1-11 Link Here
1
DROP TABLE IF EXISTS reserve_group;
1
DROP TABLE IF EXISTS hold_group;
2
CREATE TABLE reserve_group (
2
CREATE TABLE hold_group (
3
  reserve_group_id int unsigned NOT NULL AUTO_INCREMENT,
3
  hold_group_id int unsigned NOT NULL AUTO_INCREMENT,
4
  PRIMARY KEY (reserve_group_id)
4
  PRIMARY KEY (hold_group_id)
5
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
5
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
6
6
7
ALTER TABLE reserves ADD COLUMN reserve_group_id int unsigned NULL DEFAULT NULL;
7
ALTER TABLE reserves ADD COLUMN hold_group_id int unsigned NULL DEFAULT NULL;
8
ALTER TABLE reserves ADD CONSTRAINT reserves_ibfk_6 FOREIGN KEY (reserve_group_id) REFERENCES reserve_group (reserve_group_id) ON DELETE SET NULL ON UPDATE CASCADE;
8
ALTER TABLE reserves ADD CONSTRAINT reserves_ibfk_6 FOREIGN KEY (hold_group_id) REFERENCES hold_group (hold_group_id) ON DELETE SET NULL ON UPDATE CASCADE;
9
9
10
ALTER TABLE old_reserves ADD COLUMN reserve_group_id int unsigned NULL DEFAULT NULL;
10
ALTER TABLE old_reserves ADD COLUMN hold_group_id int unsigned NULL DEFAULT NULL;
11
ALTER TABLE old_reserves ADD CONSTRAINT old_reserves_ibfk_5 FOREIGN KEY (reserve_group_id) REFERENCES reserve_group (reserve_group_id) ON DELETE SET NULL ON UPDATE CASCADE;
11
ALTER TABLE old_reserves ADD CONSTRAINT old_reserves_ibfk_5 FOREIGN KEY (hold_group_id) REFERENCES hold_group (hold_group_id) ON DELETE SET NULL ON UPDATE CASCADE;
(-)a/installer/data/mysql/kohastructure.sql (-9 / +9 lines)
Lines 1770-1776 CREATE TABLE `old_issues` ( -- lists items that were checked out and have been r Link Here
1770
    ON DELETE SET NULL ON UPDATE SET NULL,
1770
    ON DELETE SET NULL ON UPDATE SET NULL,
1771
  CONSTRAINT `old_issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`)
1771
  CONSTRAINT `old_issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`)
1772
    ON DELETE SET NULL ON UPDATE SET NULL,
1772
    ON DELETE SET NULL ON UPDATE SET NULL,
1773
  CONSTRAINT `old_reserves_ibfk_5` FOREIGN KEY (reserve_group_id) REFERENCES reserve_group (reserve_group_id)
1773
  CONSTRAINT `old_reserves_ibfk_5` FOREIGN KEY (hold_group_id) REFERENCES hold_group (hold_group_id)
1774
    ON DELETE SET NULL ON UPDATE CASCADE
1774
    ON DELETE SET NULL ON UPDATE CASCADE
1775
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1775
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1776
1776
Lines 1873-1879 CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha Link Here
1873
  `suspend` BOOLEAN NOT NULL DEFAULT 0,
1873
  `suspend` BOOLEAN NOT NULL DEFAULT 0,
1874
  `suspend_until` DATETIME NULL DEFAULT NULL,
1874
  `suspend_until` DATETIME NULL DEFAULT NULL,
1875
  `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting
1875
  `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting
1876
  `reserve_group_id` int unsigned NULL DEFAULT NULL,  -- Id used on reservations spanning multiple titles
1876
  `hold_group_id` int unsigned NULL DEFAULT NULL,  -- Id used on reservations spanning multiple titles
1877
  PRIMARY KEY (`reserve_id`),
1877
  PRIMARY KEY (`reserve_id`),
1878
  KEY priorityfoundidx (priority,found),
1878
  KEY priorityfoundidx (priority,found),
1879
  KEY `borrowernumber` (`borrowernumber`),
1879
  KEY `borrowernumber` (`borrowernumber`),
Lines 1886-1902 CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha Link Here
1886
  CONSTRAINT `reserves_ibfk_3` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE,
1886
  CONSTRAINT `reserves_ibfk_3` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE,
1887
  CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE,
1887
  CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE,
1888
  CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE,
1888
  CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE,
1889
  CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`reserve_group_id`) REFERENCES `reserve_group` (`reserve_group_id`) ON DELETE SET NULL ON UPDATE CASCADE
1889
  CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`hold_group_id`) REFERENCES `hold_group` (`hold_group_id`) ON DELETE SET NULL ON UPDATE CASCADE
1890
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1890
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1891
1891
1892
--
1892
--
1893
-- Table structure for table reserve_group
1893
-- Table structure for table hold_group
1894
--
1894
--
1895
1895
1896
DROP TABLE IF EXISTS `reserve_group`;
1896
DROP TABLE IF EXISTS `hold_group`;
1897
CREATE TABLE `reserve_group` (
1897
CREATE TABLE `hold_group` (
1898
  `reserve_group_id` int unsigned NOT NULL AUTO_INCREMENT,
1898
  `hold_group_id` int unsigned NOT NULL AUTO_INCREMENT,
1899
  PRIMARY KEY(`reserve_group_id`)
1899
  PRIMARY KEY(`hold_group_id`)
1900
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1900
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1901
1901
1902
--
1902
--
Lines 1924-1930 CREATE TABLE `old_reserves` ( -- this table holds all holds/reserves that have b Link Here
1924
  `suspend` BOOLEAN NOT NULL DEFAULT 0, -- in this hold suspended (1 for yes, 0 for no)
1924
  `suspend` BOOLEAN NOT NULL DEFAULT 0, -- in this hold suspended (1 for yes, 0 for no)
1925
  `suspend_until` DATETIME NULL DEFAULT NULL, -- the date this hold is suspended until (NULL for infinitely)
1925
  `suspend_until` DATETIME NULL DEFAULT NULL, -- the date this hold is suspended until (NULL for infinitely)
1926
  `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting
1926
  `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting
1927
  `reserve_group_id` int unsigned NULL DEFAULT NULL,  -- The id of a group of titles reservations fulfilled when one title is picked
1927
  `hold_group_id` int unsigned NULL DEFAULT NULL,  -- The id of a group of titles reservations fulfilled when one title is picked
1928
  PRIMARY KEY (`reserve_id`),
1928
  PRIMARY KEY (`reserve_id`),
1929
  KEY `old_reserves_borrowernumber` (`borrowernumber`),
1929
  KEY `old_reserves_borrowernumber` (`borrowernumber`),
1930
  KEY `old_reserves_biblionumber` (`biblionumber`),
1930
  KEY `old_reserves_biblionumber` (`biblionumber`),
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/reserve-group-modal.inc (-27 lines)
Lines 1-27 Link Here
1
<div id="reserve-group-modal" class="modal hide" tabindex="-1" role="dialog" aria-labelledby="reserve-group-modal-label" aria-hidden="true">
2
    <div class="modal-header">
3
        <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">×</button>
4
        <h3 id="reserve-group-modal-label">Reserve group</h3>
5
    </div>
6
    <div class="modal-body">
7
        <div id="loading"> <img src="[% interface %]/[% theme %]/img/loading-small.gif" alt="" /> Loading </div>
8
    </div>
9
    <div class="modal-footer">
10
        <button class="btn" data-dismiss="modal" aria-hidden="true">Close</button>
11
    </div>
12
</div>
13
14
<script>
15
  $(document).ready(function() {
16
    $('body').on('click', 'a.reserve-group', function() {
17
      var href = $(this).attr('href');
18
      $('#reserve-group-modal .modal-body').load(href + " #main");
19
      $('#reserve-group-modal').modal('show');
20
      return false;
21
    })
22
23
    $('#reserve-group-modal').on('hidden', function(){
24
        $('#reserve-group-modal .modal-body').html('<div id="loading"><img src="[% interface %]/[% theme %]/img/loading-small.gif" alt="" /> ' + _('Loading') + '</div>');
25
    });
26
  });
27
</script>
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc (-1 / +1 lines)
Lines 44-49 Link Here
44
    var RESUME_HOLD_ERROR_NOT_FOUND = _("Unable to resume, hold not found");
44
    var RESUME_HOLD_ERROR_NOT_FOUND = _("Unable to resume, hold not found");
45
    var CURRENT = _(" (current) ");
45
    var CURRENT = _(" (current) ");
46
    var PART_OF_A = _("(part of a %s)");
46
    var PART_OF_A = _("(part of a %s)");
47
    var RESERVE_GROUP = _("reserve group");
47
    var HOLD_GROUP = _("hold group");
48
//]]>
48
//]]>
49
</script>
49
</script>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt (-3 / +3 lines)
Lines 61-68 Link Here
61
                [% IF ( reserveloo.author ) %]
61
                [% IF ( reserveloo.author ) %]
62
                    <p> by [% reserveloo.author %]</p>
62
                    <p> by [% reserveloo.author %]</p>
63
                [% END %]
63
                [% END %]
64
                [% IF reserveloo.reserve_group_id %]
64
                [% IF reserveloo.hold_group_id %]
65
                    <p>(part of a <a class="reserve-group" href="/cgi-bin/koha/reserve/reserve-group.pl?reserve_group_id=[% reserveloo.reserve_group_id %]">reserve group</a>)</p>
65
                    <p>(part of a <a class="hold-group" href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[% reserveloo.hold_group_id %]">reserve group</a>)</p>
66
                [% END %]
66
                [% END %]
67
            </td>
67
            </td>
68
        [% ELSE %]
68
        [% ELSE %]
Lines 219-223 Link Here
219
[% END %]
219
[% END %]
220
220
221
[%# TODO: this modul needs to be separated to html and js part to be icnluded correctly %]
221
[%# TODO: this modul needs to be separated to html and js part to be icnluded correctly %]
222
[% INCLUDE 'reserve-group-modal.inc' %]
222
[% INCLUDE 'hold-group-modal.inc' %]
223
[% INCLUDE 'intranet-bottom.inc' %]
223
[% INCLUDE 'intranet-bottom.inc' %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt (-1 / +1 lines)
Lines 666-670 Link Here
666
    </script>
666
    </script>
667
[% END %]
667
[% END %]
668
668
669
[% INCLUDE 'reserve-group-modal.inc' %]
669
[% INCLUDE 'hold-group-modal.inc' %]
670
[% INCLUDE 'intranet-bottom.inc' %]
670
[% INCLUDE 'intranet-bottom.inc' %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/reserve-group.tt (-9 / +9 lines)
Lines 1-12 Link Here
1
[% USE Biblio %]
1
[% USE Biblio %]
2
[% INCLUDE 'doc-head-open.inc' %]
2
[% INCLUDE 'doc-head-open.inc' %]
3
  <title>Koha &rsaquo; Circulation &rsaquo; Holds &rsaquo; Holds group ([% reserve_group_id %])</title>
3
  <title>Koha &rsaquo; Circulation &rsaquo; Holds &rsaquo; Holds group ([% hold_group_id %])</title>
4
  [% INCLUDE 'doc-head-close.inc' %]
4
  [% INCLUDE 'doc-head-close.inc' %]
5
</head>
5
</head>
6
<body id="reserve-reserve-group">
6
<body id="hold.hold-group">
7
  <h1>Holds group ([% reserve_group_id %])</h1>
7
  <h1>Holds group ([% hold_group_id %])</h1>
8
  <div id="main">
8
  <div id="main">
9
    [% IF reserves.size %]
9
    [% IF holds.size %]
10
      <table>
10
      <table>
11
        <thead>
11
        <thead>
12
          <tr>
12
          <tr>
Lines 16-27 Link Here
16
          </tr>
16
          </tr>
17
        </thead>
17
        </thead>
18
        <tbody>
18
        <tbody>
19
          [% FOREACH reserve IN reserves %]
19
          [% FOREACH hold IN holds %]
20
            [% biblio = Biblio.Get(reserve.biblionumber) %]
20
            [% biblio = Biblio.Get(hold.biblionumber) %]
21
            <tr>
21
            <tr>
22
              <td><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber %]">[% biblio.title %]</a></td>
22
              <td><a href="/cgi-bin/koha/hold.request.pl?biblionumber=[% biblio.biblionumber %]">[% biblio.title %]</a></td>
23
              <td>[% reserve.priority %]</td>
23
              <td>[% hold.priority %]</td>
24
              <td>[% reserve.reservenotes %]</td>
24
              <td>[% hold.reservenotes %]</td>
25
            </tr>
25
            </tr>
26
          [% END %]
26
          [% END %]
27
        </tbody>
27
        </tbody>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt (-3 / +3 lines)
Lines 857-864 function checkMultiHold() { Link Here
857
                 <input type="hidden" name="itemnumber" value="" />
857
                 <input type="hidden" name="itemnumber" value="" />
858
            [% END %]
858
            [% END %]
859
    [% END %]
859
    [% END %]
860
            [% IF reserveloo.reserve_group_id %]
860
            [% IF reserveloo.hold_group_id %]
861
                <div>(part of a <a href="/cgi-bin/koha/reserve/reserve-group.pl?reserve_group_id=[% reserveloo.reserve_group_id %]" class="reserve-group">reserve group</a>)</div>
861
                <div>(part of a <a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[% reserveloo.hold_group_id %]" class="hold-group">hold group</a>)</div>
862
            [% END %]
862
            [% END %]
863
        </td>
863
        </td>
864
864
Lines 923-928 function checkMultiHold() { Link Here
923
</div>
923
</div>
924
</div>
924
</div>
925
925
926
[% INCLUDE 'reserve-group-modal.inc' %]
926
[% INCLUDE 'hold-group-modal.inc' %]
927
927
928
[% INCLUDE 'intranet-bottom.inc' %]
928
[% INCLUDE 'intranet-bottom.inc' %]
(-)a/koha-tmpl/intranet-tmpl/prog/js/holds.js (-2 / +2 lines)
Lines 42-50 $(document).ready(function() { Link Here
42
                                title += " - <span class='" + span_class + "'>" + oObj.itemnotes + "</span>"
42
                                title += " - <span class='" + span_class + "'>" + oObj.itemnotes + "</span>"
43
                            }
43
                            }
44
44
45
                            if (oObj.reserve_group_id) {
45
                            if (oObj.hold_group_id) {
46
                              title += '<br>';
46
                              title += '<br>';
47
                              var link = '<a class="reserve-group" href="/cgi-bin/koha/reserve/reserve-group.pl?reserve_group_id=' + oObj.reserve_group_id + '">' + RESERVE_GROUP +'</a>'
47
                              var link = '<a class="hold-group" href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=' + oObj.hold_group_id + '">' + HOLD_GROUP +'</a>'
48
                              title += '<span>' + PART_OF_A.format(link) + '</span>';
48
                              title += '<span>' + PART_OF_A.format(link) + '</span>';
49
                            }
49
                            }
50
50
(-)a/reserve/reserve-group.pl (-5 / +5 lines)
Lines 24-42 use C4::Reserves; Link Here
24
24
25
my $cgi = new CGI;
25
my $cgi = new CGI;
26
my ($template, $loggedinuser, $cookie) = get_template_and_user({
26
my ($template, $loggedinuser, $cookie) = get_template_and_user({
27
    template_name   => "reserve/reserve-group.tt",
27
    template_name   => "reserve/hold-group.tt",
28
    query           => $cgi,
28
    query           => $cgi,
29
    type            => "intranet",
29
    type            => "intranet",
30
    authnotrequired => 0,
30
    authnotrequired => 0,
31
    flagsrequired   => { circulate => 'circulate_remaining_permissions' },
31
    flagsrequired   => { circulate => 'circulate_remaining_permissions' },
32
});
32
});
33
33
34
my $reserve_group_id = $cgi->param('reserve_group_id');
34
my $hold_group_id = $cgi->param('hold_group_id');
35
my @reserves = GetReserveGroupReserves($reserve_group_id);
35
my @reserves = GetHoldGroupHolds($hold_group_id);
36
36
37
$template->param(
37
$template->param(
38
    reserve_group_id => $reserve_group_id,
38
    hold_group_id => $hold_group_id,
39
    reserves => \@reserves,
39
    holds => \@holds,
40
);
40
);
41
41
42
output_html_with_http_headers $cgi, $cookie, $template->output;
42
output_html_with_http_headers $cgi, $cookie, $template->output;
(-)a/reserve/placerequest.pl (-3 / +3 lines)
Lines 85-93 if (defined $checkitem && $checkitem ne ''){ Link Here
85
85
86
if ( $type eq 'str8' && $borrower ) {
86
if ( $type eq 'str8' && $borrower ) {
87
87
88
    my $reserve_group_id;
88
    my $hold_group_id;
89
    if ($multi_hold && $requestany) {
89
    if ($multi_hold && $requestany) {
90
        $reserve_group_id = AddReserveGroup();
90
        $hold_group_id = AddReserveGroup();
91
    }
91
    }
92
92
93
    foreach my $biblionumber ( keys %bibinfos ) {
93
    foreach my $biblionumber ( keys %bibinfos ) {
Lines 116-122 if ( $type eq 'str8' && $borrower ) { Link Here
116
            AddReserve($branch, $borrower->{'borrowernumber'}, $biblionumber,
116
            AddReserve($branch, $borrower->{'borrowernumber'}, $biblionumber,
117
                [$biblionumber], $bibinfo->{rank}, $startdate, $expirationdate,
117
                [$biblionumber], $bibinfo->{rank}, $startdate, $expirationdate,
118
                $notes, $bibinfo->{title}, $checkitem, $found, $itemtype,
118
                $notes, $bibinfo->{title}, $checkitem, $found, $itemtype,
119
                $reserve_group_id);
119
                $hold_group_id);
120
        } else {
120
        } else {
121
            # place a request on 1st available
121
            # place a request on 1st available
122
            for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) {
122
            for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) {
(-)a/svc/holds (-1 / +1 lines)
Lines 102-108 while ( my $h = $holds_rs->next() ) { Link Here
102
        waiting_here   => $h->branch()->branchcode() eq $branch,
102
        waiting_here   => $h->branch()->branchcode() eq $branch,
103
        priority       => $h->priority(),
103
        priority       => $h->priority(),
104
        itemtype_limit => $itemtype_limit,
104
        itemtype_limit => $itemtype_limit,
105
        reserve_group_id => $h->reserve_group_id,
105
        hold_group_id => $h->hold_group_id,
106
        subtitle       => GetRecordValue(
106
        subtitle       => GetRecordValue(
107
            'subtitle',
107
            'subtitle',
108
            GetMarcBiblio({ biblionumber => $biblionumber }),
108
            GetMarcBiblio({ biblionumber => $biblionumber }),
(-)a/t/db_dependent/Reserves/ReserveCount.t (-12 / +11 lines)
Lines 50-56 my $biblio = $builder->build( { source => 'Biblio', } ); Link Here
50
my $biblionumber = $biblio->{biblionumber};
50
my $biblionumber = $biblio->{biblionumber};
51
51
52
# Use AddReserve instead of TestBuilder because i don't manage
52
# Use AddReserve instead of TestBuilder because i don't manage
53
# to make TestBuilder set reserve_group_id to null. Idea ?
53
# to make TestBuilder set hold_group_id to null. Idea ?
54
my $reserve_id = AddReserve($branchcode, $borrowernumber,
54
my $reserve_id = AddReserve($branchcode, $borrowernumber,
55
$biblionumber, $biblionumber, 1, undef, undef, undef
55
$biblionumber, $biblionumber, 1, undef, undef, undef
56
$biblio->{title}, undef, undef, undef);
56
$biblio->{title}, undef, undef, undef);
Lines 58-66 $biblio->{title}, undef, undef, undef); Link Here
58
is(GetReserveCount($borrowernumber), 1, 'Test borrower has 1 reserve.');
58
is(GetReserveCount($borrowernumber), 1, 'Test borrower has 1 reserve.');
59
59
60
my $reserves_group = $builder->build({
60
my $reserves_group = $builder->build({
61
    source => 'ReserveGroup',
61
    source => 'HoldGroup',
62
    value => {
62
    value => {
63
        reserve_group_id => 1
63
        hold_group_id => 1
64
    }
64
    }
65
});
65
});
66
66
Lines 68-113 my $reserve2 = $builder->build({ Link Here
68
    source => 'Reserve',
68
    source => 'Reserve',
69
    value => {
69
    value => {
70
        borrowernumber => $borrowernumber,
70
        borrowernumber => $borrowernumber,
71
        reserve_group_id => 1
71
        hold_group_id => 1
72
    }
72
    }
73
});
73
});
74
my $reserve3 = $builder->build({
74
my $reserve3 = $builder->build({
75
    source => 'Reserve',
75
    source => 'Reserve',
76
    value => {
76
    value => {
77
        borrowernumber => $borrowernumber,
77
        borrowernumber => $borrowernumber,
78
        reserve_group_id => 1
78
        hold_group_id => 1
79
    }
79
    }
80
});
80
});
81
81
82
is(GetReserveCount($borrowernumber), 2, 'Test borrower has 2 reserve.');
82
is(GetReserveCount($borrowernumber), 2, 'Test borrower has 2 reserve.');
83
83
84
my $reserves_group2 = $builder->build({
84
my $reserves_group2 = $builder->build({
85
    source => 'ReserveGroup',
85
    source => 'HoldGroup',
86
    value => {
86
    value => {
87
        reserve_group_id => 2
87
        hold_group_id => 2
88
    }
88
    }
89
});
89
});
90
my $reserve_group_id2 = $reserves_group2->{reserve_group_id};
90
my $hold_group_id2 = $reserves_group2->{hold_group_id};
91
91
92
my $reserve4 = $builder->build({
92
my $reserve4 = $builder->build({
93
    source => 'Reserve',
93
    source => 'Reserve',
94
    value => {
94
    value => {
95
        borrowernumber => $borrowernumber,
95
        borrowernumber => $borrowernumber,
96
        reserve_group_id => 2
96
        hold_group_id => 2
97
    }
97
    }
98
});
98
});
99
my $reserve5 = $builder->build({
99
my $reserve5 = $builder->build({
100
    source => 'Reserve',
100
    source => 'Reserve',
101
    value => {
101
    value => {
102
        borrowernumber => $borrowernumber,
102
        borrowernumber => $borrowernumber,
103
        reserve_group_id => 2
103
        hold_group_id => 2
104
    }
104
    }
105
});
105
});
106
my $reserve6 = $builder->build({
106
my $reserve6 = $builder->build({
107
    source => 'Reserve',
107
    source => 'Reserve',
108
    value => {
108
    value => {
109
        borrowernumber => $borrowernumber,
109
        borrowernumber => $borrowernumber,
110
        reserve_group_id => 2
110
        hold_group_id => 2
111
    }
111
    }
112
});
112
});
113
113
114
- 

Return to bug 15516