Bugzilla – Attachment 72536 Details for
Bug 20303
Receive order fails if no "authorised_by" value
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20303: Do not explode when receiving an order if authorisedby not set
Bug-20303-Do-not-explode-when-receiving-an-order-i.patch (text/plain), 1.56 KB, created by
Josef Moravec
on 2018-03-08 12:55:25 UTC
(
hide
)
Description:
Bug 20303: Do not explode when receiving an order if authorisedby not set
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-03-08 12:55:25 UTC
Size:
1.56 KB
patch
obsolete
>From f6d2ee038bfa525873c7db9119191b824f8686a5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 27 Feb 2018 15:54:38 -0300 >Subject: [PATCH] Bug 20303: Do not explode when receiving an order if > authorisedby not set > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > acqui/orderreceive.pl | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl >index e876942..c88a533 100755 >--- a/acqui/orderreceive.pl >+++ b/acqui/orderreceive.pl >@@ -185,6 +185,12 @@ my $suggestion = GetSuggestionInfoFromBiblionumber($order->{biblionumber}); > > my $authorisedby = $order->{authorisedby}; > my $authorised_patron = Koha::Patrons->find( $authorisedby ); >+if ( $authorised_patron ) { # This should not happen unless there was a migration issue (or very old install?) >+ $template->param( >+ memberfirstname => $authorised_patron->firstname || "", >+ membersurname => $authorised_patron->surname || "", >+ ); >+} > > my $budget = GetBudget( $order->{budget_id} ); > >@@ -217,8 +223,6 @@ $template->param( > ecost => $ecost, > unitprice => $unitprice, > tax_rate => $tax_rate, >- memberfirstname => $authorised_patron->firstname || "", >- membersurname => $authorised_patron->surname || "", > invoiceid => $invoice->{invoiceid}, > invoice => $invoice->{invoicenumber}, > datereceived => $datereceived, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20303
:
72281
|
72522
| 72536