From b5506c18ad01a7571ee4cc56275cfc872f530f56 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 8 Mar 2018 14:57:23 +0000 Subject: [PATCH] Bug 15668 - Add columns configuraiton to intranet details page TODO: Make this account for otherholdings too - see bug 16759 To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Don't works, Be sad, get motivated, finish the patchset, get a hug from kidclamp --- admin/columns_settings.yml | 52 ++++++++++++++++++++++ .../prog/en/modules/catalogue/detail.tt | 52 ++++++++++++---------- 2 files changed, 80 insertions(+), 24 deletions(-) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index f56a745..8231a85 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -83,6 +83,58 @@ modules: - columnname: actions + catalogue: + detail: + holdings_table: + - + columnname: holdings_checkbox + cannot_be_toggled: 1 + cannot_be_modified: 1 + - + columnname: holdings_itype + - + columnname: holdings_holdingbranch + - + columnname: holdings_homebranch + - + columnname: holdings_ccode + - + columnname: holdings_itemcallnumber + - + columnname: holdings_status + - + columnname: holdings_lastseen + - + columnname: holdings_barcode + - + columnname: holdings_enumchron + - + columnname: holdings_uri + - + columnname: holdings_copynumber + - + columnname: holdings_stocknumber + - + columnname: holdings_materials + - + columnname: holdings_itemnotes + - + columnname: holdings_itemnotes_nonpublic + - + columnname: holdings_spinelabel + - + columnname: holdings_hostrecord + - + columnname: holdings_usedin + - + columnname: holdings_usedin_col + - + columnname: holdings_course_reserves + - + columnname: holdings_actions + cannot_be_toggled: 1 + cannot_be_modified: 1 + cataloguing: additem: itemst: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index e2c8e8a..c0fa966 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -3,6 +3,7 @@ [% USE AuthorisedValues %] [% USE Branches %] [% USE Biblio %] +[% USE ColumnsSettings %] [% IF Koha.Preference('AmazonAssocTag') %] [% AmazonAssocTag = '?tag=' _ Koha.Preference('AmazonAssocTag') %] @@ -329,27 +330,27 @@ - [% IF (StaffDetailItemSelection) %][% END %] - [% IF ( item_level_itypes ) %][% END %] - - - [% IF ( itemdata_ccode ) %][% END %] - - - - - [% IF ( volinfo ) %][% END %] - [% IF ( itemdata_uri ) %][% END %] - [% IF ( itemdata_copynumber ) %][% END %] - [% IF ( itemdata_stocknumber ) %][% END %] - [% IF materials %][% END %] - [% IF ( itemdata_itemnotes ) %][% END %] - [% IF ( itemdata_nonpublicnotes ) %][% END %] - [% IF ( SpineLabelShowPrintOnBibDetails ) %][% END %] - [% IF ( hostrecords ) %][% END %] - [% IF ( analyze ) %][% END %] - [% IF ( ShowCourseReserves ) %][% END %] - [% IF ( CAN_user_editcatalogue_edit_items ) %][% END %] + [% IF (StaffDetailItemSelection) %][% END %] + [% IF ( item_level_itypes ) %][% END %] + + + [% IF ( itemdata_ccode ) %][% END %] + + + + + [% IF ( volinfo ) %][% END %] + [% IF ( itemdata_uri ) %][% END %] + [% IF ( itemdata_copynumber ) %][% END %] + [% IF ( itemdata_stocknumber ) %][% END %] + [% IF materials %][% END %] + [% IF ( itemdata_itemnotes ) %][% END %] + [% IF ( itemdata_nonpublicnotes ) %][% END %] + [% IF ( SpineLabelShowPrintOnBibDetails ) %][% END %] + [% IF ( hostrecords ) %][% END %] + [% IF ( analyze ) %][% END %] + [% IF ( ShowCourseReserves ) %][% END %] + [% IF ( CAN_user_editcatalogue_edit_items ) %][% END %] @@ -1053,8 +1054,9 @@ $(document).ready(function() { var ids = ['holdings_table', 'otherholdings_table']; - + var columns_settings = [ [% ColumnsSettings.GetColumns('catalogue', 'detail','holdings_table','json') %], [% ColumnsSettings.GetColumns('catalogue', 'detail','otherholdings_table','json') %] ]; for (var i in ids) { + console.log( i ); var id = ids[i]; var dt_parameters = { 'sDom': 't', @@ -1062,9 +1064,11 @@ 'bAutoWidth': false, "aoColumnDefs": [ { "bSortable": false, "bSearchable": false, 'aTargets': [ 'NoSort' ] } - ] + ], + "bKohaColumnsUseNames": true, + "sDom": 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>', }; - var table = KohaTable(id, dt_parameters, null, 'with_filters'); + var table = KohaTable(id, dt_parameters, columns_settings[i], 'with_filters'); } [% IF Koha.Preference('AcquisitionDetails') %] -- 2.1.4
Item typeCurrent locationHome libraryCollectionCall numberStatusLast seenBarcodeSerial enumeration / chronologyURLCopy numberInventory numberMaterials specifiedPublic notesNon-public notesSpine labelHost recordsUsed inCourse Reserves Item typeCurrent locationHome libraryCollectionCall numberStatusLast seenBarcodeSerial enumeration / chronologyURLCopy numberInventory numberMaterials specifiedPublic notesNon-public notesSpine labelHost recordsUsed inCourse Reserves