From cf129b6156dc965c135f14dd69b2b43db1166ed3 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Tue, 30 Jan 2018 18:25:13 +0000 Subject: [PATCH] Bug 20103: Remove Readonly::XS from PerlDependencies Content-Type: text/plain; charset=utf-8 While having Readonly::XS is a good thing on slower systems the CPAN page for Readonly says it isn't required to be used directly, so we don't need to check for it. Additionally, even reading /usr/share/perl5/Readonly.pm you see "# Modern perl doesn't need Readonly::XS" on an if statement checking for version 5.8! Koha requires 5.20 (see C4::Log::cronlogaction's use of caller). TEST PLAN --------- Can you run a fresh install? Does the about page list Readonly::XS? It shouldn't after the patch. Run koha qa test tools Signed-off-by: Marcel de Rooy --- C4/Installer/PerlDependencies.pm | 5 ----- 1 file changed, 5 deletions(-) diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm index 8961453..2a7a99a 100644 --- a/C4/Installer/PerlDependencies.pm +++ b/C4/Installer/PerlDependencies.pm @@ -852,11 +852,6 @@ our $PERL_DEPS = { 'required' => '0', 'min_ver' => '0.01' }, - 'Readonly::XS' => { - 'usage' => 'Make script happy', - 'required' => '0', - 'min_ver' => '0.01' - }, 'Bytes::Random::Secure' => { usage => 'Core', required => 1, -- 2.1.4