From e9d0beb02d53821dbcc8b7cdbddac5e02aa1714d Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 11 Oct 2017 14:41:17 +0200 Subject: [PATCH 2/3] Bug 18625: (QA follow-up) Simplify update_lastseen No need to check the pref. Signed-off-by: Marcel de Rooy --- C4/SIP/ILS/Patron.pm | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm index 0d96dd23fe..a0aafb6e35 100644 --- a/C4/SIP/ILS/Patron.pm +++ b/C4/SIP/ILS/Patron.pm @@ -444,12 +444,8 @@ sub charge_denied { sub update_lastseen { my $self = shift; - my $p; - if (C4::Context->preference('TrackLastPatronActivity') - && $p = Koha::Patrons->find({ borrowernumber => $self->{borrowernumber} })) { - $p->track_login; - } - return; + my $kohaobj = Koha::Patrons->find( $self->{borrowernumber} ); + $kohaobj->track_login if $kohaobj; # track_login checks the pref } sub _get_address { -- 2.14.3