Bugzilla – Attachment 7256 Details for
Bug 7454
Sip renewal all response returns incorrect info
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-7454-Initialize-return-arrays-in-ILS-Transaction.patch (text/plain), 1.43 KB, created by
Colin Campbell
on 2012-01-20 15:14:49 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2012-01-20 15:14:49 UTC
Size:
1.43 KB
patch
obsolete
>From aa0579d53ef6c1e641da4029e16cb6ee2bdc26a1 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Tue, 17 Jan 2012 14:46:09 +0000 >Subject: [PATCH] Bug 7454 Initialize return arrays in > ILS/Transaction/RenewAll > >Explicitly clear these arrays and update them directly. >In practice item numbers were already in them when called >so that more items were being returned than were actually >renewed (or failed) >--- > C4/SIP/ILS/Transaction/RenewAll.pm | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/RenewAll.pm b/C4/SIP/ILS/Transaction/RenewAll.pm >index a712806..2e49bf7 100644 >--- a/C4/SIP/ILS/Transaction/RenewAll.pm >+++ b/C4/SIP/ILS/Transaction/RenewAll.pm >@@ -38,6 +38,8 @@ sub do_renew_all { > my $patron = $self->{patron}; # SIP's patron > my $borrower = GetMember('cardnumber'=>$patron->id); # Koha's patron > my $all_ok = 1; >+ $self->{renewed} = []; >+ $self->{unrenewed} = []; > foreach my $itemx (@{$patron->{items}}) { > my $item_id = $itemx->{barcode}; > my $item = new ILS::Item $item_id; >@@ -52,9 +54,9 @@ sub do_renew_all { > $self->do_renew_for($borrower); > if ($self->ok) { > $item->{due_date} = $self->{due}; >- push @{$self->renewed }, $item_id; >+ push @{$self->{renewed} }, $item_id; > } else { >- push @{$self->unrenewed}, $item_id; >+ push @{$self->{unrenewed}}, $item_id; > } > } > $self->ok($all_ok); >-- >1.7.5.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7454
:
7256
|
7750