Bugzilla – Attachment 72597 Details for
Bug 18570
Password recovery e-mail only sent after message queue is processed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18570: QA Followup - Improved POD
Bug-18570-QA-Followup---Improved-POD.patch (text/plain), 3.19 KB, created by
Mark Tompsett
on 2018-03-09 14:14:07 UTC
(
hide
)
Description:
Bug 18570: QA Followup - Improved POD
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-03-09 14:14:07 UTC
Size:
3.19 KB
patch
obsolete
>From fae757d8a9b3593804830a238b96ddbbc47920fe Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 9 Mar 2018 11:54:16 +0000 >Subject: [PATCH] Bug 18570: QA Followup - Improved POD > >This tweaks the perldoc for SendQueuedMessages and adds >some for _get_unsent_messages. > >TEST PLAN >--------- > >perldoc C4::Letters >-- look at _add_attachments (ugly), _get_unsent_messages (non-existent), > SendQueuedMessages (no reference to borrowernumber or letter_code). >apply patch >perldoc C4::Letters >-- confirm that SendQueuedMessages and _get_unsent_messages > have reasonable POD information. >-- notice how _add_attachments' POD is now readable > >run koha qa test tools >--- > C4/Letters.pm | 48 +++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 37 insertions(+), 11 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 841362a..b76338e 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1026,10 +1026,22 @@ ENDSQL > > =head2 SendQueuedMessages ([$hashref]) > >- my $sent = SendQueuedMessages({ verbose => 1, limit => 50 }); >+ my $sent = SendQueuedMessages({ >+ letter_code => $letter_code, >+ borrowernumber => $who_letter_is_for, >+ limit => 50, >+ verbose => 1 >+ }); >+ >+Sends all of the 'pending' items in the message queue, unless >+parameters are passed. > >-Sends all of the 'pending' items in the message queue, unless the optional >-limit parameter is passed too. The verbose parameter is also optional. >+The letter_code, borrowernumber and limit parameters are used >+to build a parameter set for _get_unsent_messages, thus limiting >+which pending messages will be processed. They are all optional. >+ >+The verbose parameter can be used to generate debugging output. >+It is also optional. > > Returns number of messages sent. > >@@ -1229,15 +1241,15 @@ sub ResendMessage { > > =head2 _add_attachements > >-named parameters: >-letter - the standard letter hashref >-attachments - listref of attachments. each attachment is a hashref of: >- type - the mime type, like 'text/plain' >- content - the actual attachment >- filename - the name of the attachment. >-message - a MIME::Lite object to attach these to. >+ named parameters: >+ letter - the standard letter hashref >+ attachments - listref of attachments. each attachment is a hashref of: >+ type - the mime type, like 'text/plain' >+ content - the actual attachment >+ filename - the name of the attachment. >+ message - a MIME::Lite object to attach these to. > >-returns your letter object, with the content updated. >+ returns your letter object, with the content updated. > > =cut > >@@ -1273,6 +1285,20 @@ sub _add_attachments { > > } > >+=head2 _get_unsent_messages >+ >+ This function's parameter hash reference takes the following >+ optional named parameters: >+ message_transport_type: method of message sending (e.g. email, sms, etc.) >+ borrowernumber : who the message is to be sent >+ letter_code : type of message being sent (e.g. PASSWORD_RESET) >+ limit : maximum number of messages to send >+ >+ This function returns an array of matching hash referenced rows from >+ message_queue with some borrower information added. >+ >+=cut >+ > sub _get_unsent_messages { > my $params = shift; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18570
:
72499
|
72524
|
72525
|
72526
|
72531
|
72532
|
72533
|
72597
|
72599
|
72600
|
72601
|
72602
|
73221