From 6d680f476c62b23214dc09c7dca85932ab675ae9 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Mon, 8 Jan 2018 11:15:02 -0300
Subject: [PATCH] Bug 19935: Replace GetPendingIssues - Discharges

We should actually use Koha::Patron->checkouts here to avoid the
prefetch.

Test plan:
A patron with checkouts cannot get a discharge

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
---
 Koha/Patron/Discharge.pm | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/Koha/Patron/Discharge.pm b/Koha/Patron/Discharge.pm
index a1f4942..42eb438 100644
--- a/Koha/Patron/Discharge.pm
+++ b/Koha/Patron/Discharge.pm
@@ -6,11 +6,10 @@ use File::Temp qw( :POSIX );
 use Carp;
 
 use C4::Templates qw ( gettemplate );
-use C4::Members qw( GetPendingIssues );
 
 use Koha::Database;
 use Koha::DateUtils qw( dt_from_string output_pref );
-use Koha::Patrons;
+use Koha::Checkouts;
 
 sub count {
     my ($params) = @_;
@@ -34,13 +33,11 @@ sub can_be_discharged {
     my ($params) = @_;
     return unless $params->{borrowernumber};
 
-    my $issues = GetPendingIssues( $params->{borrowernumber} );
-    if( @$issues ) {
-        return 0;
-    }
-    else {
-        return 1;
-    }
+    my $patron = Koha::Patrons->find( $params->{borrowernumber} );
+    return unless $patron;
+
+    my $has_pending_checkouts = $patron->pending_checkouts->count;
+    return $has_pending_checkouts ? 0 : 1;
 }
 
 sub is_discharged {
-- 
2.1.4