Bugzilla – Attachment 72774 Details for
Bug 20376
"Select all" button no longer selects disabled checkboxes in Batch Record Deletion Tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20376: Select all ignores disabled checkboxes
Bug-20376-Select-all-ignores-disabled-checkboxes.patch (text/plain), 2.09 KB, created by
Biblibre Sandboxes
on 2018-03-13 13:43:35 UTC
(
hide
)
Description:
Bug 20376: Select all ignores disabled checkboxes
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2018-03-13 13:43:35 UTC
Size:
2.09 KB
patch
obsolete
>From 0eb67fb54ef9e48e9d36b471f5c3986415d9fcd9 Mon Sep 17 00:00:00 2001 >From: Maksim Sen <maksim.sen@inlibro.com> >Date: Mon, 12 Mar 2018 16:15:30 -0400 >Subject: [PATCH] Bug 20376: Select all ignores disabled checkboxes > >Test Plan: > >0.1 - find at least one biblionumber that has at least one item checked out >0.2 - find at least one biblionumber that has zero items checked out. >1 - Go into the module "Tools > Batch record deletion" >2 - in "List of biblionumbers or authority ids (one per line)" put the values you found in step 0.1 and 0.2 >3 - click continue >4 - biblionumbers with at least one item checked out should not be clickable. >5 - biblionumbers with zero items checked out should be clickable. >6 - click "Select all" and "Clear all", both buttons should change the "checked" status of the enabled AND disabled biblionumber checkboxes. >7 - apply patch >8 - click "Select all" and "Clear all", both buttons should change the "checked" status of ONLY the enabled biblionumber checkboxes. > >Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >index ae3ac4b..913905a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >@@ -185,11 +185,11 @@ > $(document).ready(function() { > $("#selectall").click(function(e){ > e.preventDefault(); >- $(".records").checkCheckboxes(); >+ $(".records").checkCheckboxes(":input[type='checkbox']:not(:disabled)"); > }); > $("#clearall").click(function(e){ > e.preventDefault(); >- $(".records").unCheckCheckboxes(); >+ $(".records").unCheckCheckboxes(":input[type='checkbox']:not(:disabled)"); > }); > $("#selectwithoutitems").click(function(e){ > e.preventDefault(); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20376
:
72726
|
72774
|
72797