Bugzilla – Attachment 728 Details for
Bug 2553
alphabetize dropdown menus
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Additional patch for the Serials statistics form using GetBranchesLoop
0004-Bug-2553-Alphabetization-of-branches-in-the-Serials.patch (text/plain), 3.09 KB, created by
Chris Cormack
on 2009-07-22 01:11:00 UTC
(
hide
)
Description:
Additional patch for the Serials statistics form using GetBranchesLoop
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2009-07-22 01:11:00 UTC
Size:
3.09 KB
patch
obsolete
>From d027fb385516c21fcd369549a0aa105475cf6a4b Mon Sep 17 00:00:00 2001 >From: Garry Collum <gcollum@gmail.com> >Date: Tue, 21 Jul 2009 21:11:29 -0400 >Subject: [PATCH] Bug 2553: Alphabetization of branches in the Serials Stats form. >Content-Type: text/plain; charset="utf-8" > >Improvement on the previous patch through the use of GetBranchesLoop. Added code so that the logged in location will be the location that is selected by default. > >Fixed a couple of minor xhtml errors. >--- > .../prog/en/modules/reports/serials_stats.tmpl | 6 +++--- > reports/serials_stats.pl | 14 +------------- > 2 files changed, 4 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tmpl >index fca21c8..7f694ca 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tmpl >@@ -73,20 +73,20 @@ > <!--/TMPL_LOOP --> > </select> > </li><li> >- <label for="branch"> >+ <label for="branchcode"> > Branch: > </label> > <select name="branchcode" id="branchcode"> > <option value="">Any Branch</option> > <!--TMPL_LOOP Name="branches"--> >- <option value="<!--TMPL_VAR Name="branchcode"-->"><!--TMPL_VAR Name="branchname"--></option> >+ <!-- TMPL_IF NAME="selected" --><option value="<!--TMPL_VAR Name="value" -->" selected="selected"><!-- TMPL_VAR NAME="branchname" --></option><!-- TMPL_ELSE --><option value="<!--TMPL_VAR Name="value"-->"><!--TMPL_VAR Name="branchname"--></option><!-- /TMPL_IF --> > <!--/TMPL_LOOP --> > </select> > > </li> > <li> > <label for="expired">Include expired subscriptions: </label> >- <input type="checkbox" name="expired" /> >+ <input type="checkbox" name="expired" id="expired" /> > </li> > </ol> > </fieldset> >diff --git a/reports/serials_stats.pl b/reports/serials_stats.pl >index ff98f34..299c661 100755 >--- a/reports/serials_stats.pl >+++ b/reports/serials_stats.pl >@@ -142,18 +142,6 @@ if($do_it){ > push(@booksellers,$row) > } > >- ## We generate branchlist >- my $branches=GetBranches(); >- my @branchloop; >- foreach (sort {$branches->{$a}->{'branchname'} cmp $branches->{$b}->{'branchname'}} keys %$branches) { >- my $thisbranch = ''; # FIXME: populate $thisbranch to preselect one >- my %row = (branchcode => $_, >- selected => ($thisbranch eq $_ ? 1 : 0), >- branchname => $branches->{$_}->{'branchname'}, >- ); >- push @branchloop, \%row; >- } >- > my @mime = ( C4::Context->preference("MIME") ); > # warn 'MIME(s): ' . join ' ', @mime; > my $CGIextChoice=CGI::scrolling_list( >@@ -167,7 +155,7 @@ if($do_it){ > CGIextChoice => $CGIextChoice, > CGIsepChoice => $CGIsepChoice, > booksellers => \@booksellers, >- branches => \@branchloop); >+ branches => GetBranchesLoop(C4::Context->userenv->{'branch'})); > } > > output_html_with_http_headers $input, $cookie, $template->output; >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2553
:
721
|
722
|
723
|
724
|
725
|
726
|
727
|
728
|
729
|
730
|
731
|
732
|
733
|
11788
|
11789