Bugzilla – Attachment 72839 Details for
Bug 19873
Make it possible to search on value 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19873 - Ability to search on 0 value
Bug-19873---Ability-to-search-on-0-value.patch (text/plain), 1.58 KB, created by
Brendan Gallagher
on 2018-03-14 11:16:09 UTC
(
hide
)
Description:
Bug 19873 - Ability to search on 0 value
Filename:
MIME Type:
Creator:
Brendan Gallagher
Created:
2018-03-14 11:16:09 UTC
Size:
1.58 KB
patch
obsolete
>From 1ee7e5b7f5588a95b0651168d05e43660aed673d Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Fri, 22 Dec 2017 14:18:44 +0000 >Subject: [PATCH] Bug 19873 - Ability to search on 0 value > >Test plan: > - create a st-numeric index in zebra conf related to > a numeric field > i.e: > yourindex 1=yourindex 4=109 > - fill a field with 0 in a biblio, > - reindex your biblios, > - search yourindex=0, > - should not work, > - apply this patch, > - test again, > - should work > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >--- > C4/Search.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index c11a61e..1eaa273 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1532,7 +1532,7 @@ sub buildQuery { > for ( my $i = 0 ; $i <= @operands ; $i++ ) { > > # COMBINE OPERANDS, INDEXES AND OPERATORS >- if ( $operands[$i] ) { >+ if ( $operands[$i] ne '' ) { > $operands[$i]=~s/^\s+//; > > # A flag to determine whether or not to add the index to the query >@@ -1677,7 +1677,7 @@ sub buildQuery { > query_desc => $query_desc, > operator => ($operators[ $i - 1 ]) ? $operators[ $i - 1 ] : '', > parsed_operand => $operand, >- original_operand => ($operands[$i]) ? $operands[$i] : '', >+ original_operand => ($operands[$i] ne '') ? $operands[$i] : '', > index => $index, > index_plus => $index_plus, > indexes_set => $indexes_set, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19873
:
70122
|
72307
|
72839
|
72840
|
74622
|
74623
|
74624