Bugzilla – Attachment 729 Details for
Bug 2553
alphabetize dropdown menus
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Additional patch for the Catalog Statistics form using GetBranchesLoop
0009-Bug-2553-Alphabetization-of-branches-in-the-catalog.patch (text/plain), 2.68 KB, created by
Chris Cormack
on 2009-07-22 01:12:00 UTC
(
hide
)
Description:
Additional patch for the Catalog Statistics form using GetBranchesLoop
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2009-07-22 01:12:00 UTC
Size:
2.68 KB
patch
obsolete
>From a0670a0da04537ab260041498c52d1d09941cda6 Mon Sep 17 00:00:00 2001 >From: Garry Collum <gcollum@gmail.com> >Date: Tue, 21 Jul 2009 20:33:26 -0400 >Subject: [PATCH] Bug 2553: Alphabetization of branches in the catalogue stats report. >Content-Type: text/plain; charset="utf-8" > >Improvement on previous patch by using GetBranchesLoop. >--- > .../prog/en/modules/reports/catalogue_stats.tmpl | 2 +- > reports/catalogue_stats.pl | 14 +------------- > 2 files changed, 2 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tmpl >index c367cec..419193e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tmpl >@@ -157,7 +157,7 @@ > <td><select name="Filter" id="branch"> > <option value=""> </option> > <!-- TMPL_LOOP NAME="CGIBranch" --> >- <!-- TMPL_IF NAME="selected" --><option value="<!-- TMPL_VAR NAME="branchcode" -->" selected="selected"><!-- TMPL_VAR NAME="branchname" --></option><!-- TMPL_ELSE --><option value="<!-- TMPL_VAR NAME="branchcode" -->"><!-- TMPL_VAR NAME="branchname" --></option><!-- /TMPL_IF --> >+ <!-- TMPL_IF NAME="selected" --><option value="<!-- TMPL_VAR NAME="value" -->" selected="selected"><!-- TMPL_VAR NAME="branchname" --></option><!-- TMPL_ELSE --><option value="<!-- TMPL_VAR NAME="value" -->"><!-- TMPL_VAR NAME="branchname" --></option><!-- /TMPL_IF --> > <!-- /TMPL_LOOP --> > </select> > </td> >diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl >index 365065f..f3b92b3 100755 >--- a/reports/catalogue_stats.pl >+++ b/reports/catalogue_stats.pl >@@ -153,18 +153,6 @@ if ($do_it) { > push @authvals, { code => $_, description => $authvals->{$_} }; > } > >- >- my $branches=GetBranches(); >- my @branchloop; >- foreach (sort {$branches->{$a}->{'branchname'} cmp $branches->{$b}->{'branchname'}} keys %$branches) { >- my $thisbranch = ''; # FIXME: populate $thisbranch to preselect one >- my %row = (branchcode => $_, >- selected => ($thisbranch eq $_ ? 1 : 0), >- branchname => $branches->{$_}->{'branchname'}, >- ); >- push @branchloop, \%row; >- } >- > my $locations = GetKohaAuthorisedValues("items.location"); > my @locations; > foreach (sort keys %$locations) { >@@ -177,7 +165,7 @@ if ($do_it) { > haslccn => $haslccn, > hascote => $hascote, > CGIItemType => $CGIitemtype, >- CGIBranch => \@branchloop, >+ CGIBranch => GetBranchesLoop(C4::Context->userenv->{'branch'}), > locationloop => \@locations, > authvals => \@authvals, > CGIextChoice => \@mime, >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2553
:
721
|
722
|
723
|
724
|
725
|
726
|
727
|
728
|
729
|
730
|
731
|
732
|
733
|
11788
|
11789