Bugzilla – Attachment 72968 Details for
Bug 20425
Reducing false positives on KOHA_VERSION
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20425: [DO NOT PUSH] False Positive AND Failure
Bug-20425-DO-NOT-PUSH-False-Positive-AND-Failure.patch (text/plain), 2.20 KB, created by
Mark Tompsett
on 2018-03-15 15:01:57 UTC
(
hide
)
Description:
Bug 20425: [DO NOT PUSH] False Positive AND Failure
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-03-15 15:01:57 UTC
Size:
2.20 KB
patch
obsolete
>From ca750d06665aff711d50f6ea4d0ff970dac8c37d Mon Sep 17 00:00:00 2001 >From: Koha instance kohadev-koha <kohadev-koha@kohadevbox> >Date: Thu, 15 Mar 2018 14:28:36 +0000 >Subject: [PATCH] Bug 20425: [DO NOT PUSH] False Positive AND Failure > >TEST PLAN >--------- >1) Apply this first patch to your kohaclone >2) run qa test tools in kohaclone > -- two issues will be raised >3) Apply the second patch to your qa-test-tools >4) run qa test tools again in your kohaclone > -- only one issue will be raised >5) confirm that the one issue is the requiring KOHA_VERSION >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 3372637..3e9b668 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1179,7 +1179,7 @@ > [% END %] > > [% IF ( NovelistSelectProfile && normalized_isbn ) %] >- <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init_[% KOHA_VERSION %].js"></script> >+ <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> > [% END %] > > [% IF ( Babeltheque ) %] >@@ -1400,7 +1400,7 @@ > </script> > <script type="text/javascript">!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets_[% KOHA_VERSION %].js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script> > [% END %] >-[% IF ( OpacStarRatings != 'disable' ) %]<script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/plugins/jquery.rating_[% KOHA_VERSION %].js"></script>[% END %] >+[% IF ( OpacStarRatings != 'disable' ) %]<script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/plugins/jquery.rating.js"></script>[% END %] > > [% IF ( OpacHighlightedWords ) %]<script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/plugins/jquery.highlight-3_[% KOHA_VERSION %].js"></script>[% END %] > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20425
: 72968 |
72972