Bugzilla – Attachment 72972 Details for
Bug 20425
Reducing false positives on KOHA_VERSION
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20425: Improve regular expression.
Bug-20425-Improve-regular-expression.patch (text/plain), 1.54 KB, created by
Mark Tompsett
on 2018-03-15 15:19:20 UTC
(
hide
)
Description:
Bug 20425: Improve regular expression.
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-03-15 15:19:20 UTC
Size:
1.54 KB
patch
obsolete
>From 47a2924e1290d603bfe933806d9f63e0ed065a47 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 15 Mar 2018 15:17:54 +0000 >Subject: [PATCH] Bug 20425: Improve regular expression. > >See comment #1 for test plan. >--- > QohA/File/Template.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/QohA/File/Template.pm b/QohA/File/Template.pm >index 256617b..4cb79ad 100644 >--- a/QohA/File/Template.pm >+++ b/QohA/File/Template.pm >@@ -113,8 +113,8 @@ sub check_forbidden_patterns { > {pattern => qr{(^|\s)(h|H)e(\s|$)}, error => "Do not assume male gender, use they/them instead (bug 18432)"}, > {pattern => qr{(^|\s)(h|H)is(\s|$)}, error => "Do not assume male gender, use they/them instead (bug 18432)"}, > {pattern => qr{\[\%[^\%\]]*$}, error => "Do not use line breaks inside template tags (bug 18675)"}, >- {pattern => qr{<link\s.*[^\]]\.css}, error => "Include [% KOHA_VERSION %] in css paths (bug 12904) - May be false positive"}, >- {pattern => qr{<script\s.*[^\]]\.js}, error => "Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive"}, >+ {pattern => qr{<link\s.*(interface|themeelang|opac-tmpl).*[^\]]\.css}, error => "Include [% KOHA_VERSION %] in css paths (bug 12904) - May be false positive"}, >+ {pattern => qr{<script\s.*(interface|themelang|opac-tmpl).*[^\]]\.js}, error => "Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive"}, > ); > > my $errors = $self->SUPER::check_forbidden_patterns($cnt, \@forbidden_patterns); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20425
:
72968
| 72972