Bugzilla – Attachment 730 Details for
Bug 2553
alphabetize dropdown menus
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Additional patch for the Checkout Statistics form using GetBranchesLoop
0010-Bug-2553-Alphabetization-of-branches-in-Checkout-St.patch (text/plain), 2.71 KB, created by
Chris Cormack
on 2009-07-22 01:13:00 UTC
(
hide
)
Description:
Additional patch for the Checkout Statistics form using GetBranchesLoop
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2009-07-22 01:13:00 UTC
Size:
2.71 KB
patch
obsolete
>From e9ed0dc9c431318a699223f10b3e34659f217751 Mon Sep 17 00:00:00 2001 >From: Garry Collum <gcollum@gmail.com> >Date: Tue, 21 Jul 2009 20:44:40 -0400 >Subject: [PATCH] Bug 2553: Alphabetization of branches in Checkout Statistics form. >Content-Type: text/plain; charset="utf-8" > >Improvement of previous patch through the use of GetBranchLoop. >--- > .../prog/en/modules/reports/issues_stats.tmpl | 2 +- > reports/issues_stats.pl | 15 +-------------- > 2 files changed, 2 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tmpl >index 5eb0101..6495a91 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tmpl >@@ -210,7 +210,7 @@ > <td><select name="Filter" id="branch"> > <option value=""> </option> > <!-- TMPL_LOOP NAME="branchloop" --> >-<!-- TMPL_IF NAME="selected" --><option value="<!-- TMPL_VAR NAME="code" -->" selected="selected"><!-- TMPL_VAR NAME="description" --></option><!-- TMPL_ELSE --><option value="<!-- TMPL_VAR NAME="code" -->"><!-- TMPL_VAR NAME="description" --></option><!-- /TMPL_IF --> >+<!-- TMPL_IF NAME="selected" --><option value="<!-- TMPL_VAR NAME="value" -->" selected="selected"><!-- TMPL_VAR NAME="branchname" --></option><!-- TMPL_ELSE --><option value="<!-- TMPL_VAR NAME="value" -->"><!-- TMPL_VAR NAME="branchname" --></option><!-- /TMPL_IF --> > <!-- /TMPL_LOOP --> > </select> > </td> >diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl >index 11ecc77..cd00424 100755 >--- a/reports/issues_stats.pl >+++ b/reports/issues_stats.pl >@@ -137,19 +137,6 @@ for my $itype ( sort {$itemtypes->{$a}->{description} cmp $itemtypes->{$b}->{des > push @itemtypeloop, { code => $itype , description => $itemtypes->{$itype}->{description} } ; > } > >-my $branches=GetBranches(); >-my @branchloop; >-foreach (sort {$branches->{$a}->{'branchname'} cmp $branches->{$b}->{'branchname'}} keys %$branches) { >- my $thisbranch = ''; # FIXME >- my %row = ( >- branchcode => $_, >- selected => ($thisbranch eq $_ ? 1 : 0), >- code => $branches->{$_}->{'branchcode'}, >- description => $branches->{$_}->{'branchname'}, >- ); >- push @branchloop, \%row; >-} >- > # location list > my @locations; > foreach (sort keys %$locations) { >@@ -178,7 +165,7 @@ $template->param( > itemtypeloop => \@itemtypeloop, > locationloop => \@locations, > ccodeloop => \@ccodes, >- branchloop => \@branchloop, >+ branchloop => GetBranchesLoop(C4::Context->userenv->{'branch'}), > hassort1=> $hassort1, > hassort2=> $hassort2, > Bsort1 => $Bsort1, >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2553
:
721
|
722
|
723
|
724
|
725
|
726
|
727
|
728
|
729
|
730
|
731
|
732
|
733
|
11788
|
11789