Bugzilla – Attachment 73025 Details for
Bug 20114
Build better $query_cgi
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20114: (follow-up) Don't add sort in query cgi
Bug-20114-follow-up-Dont-add-sort-in-query-cgi.patch (text/plain), 1.12 KB, created by
Nick Clemens
on 2018-03-16 11:43:25 UTC
(
hide
)
Description:
Bug 20114: (follow-up) Don't add sort in query cgi
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2018-03-16 11:43:25 UTC
Size:
1.12 KB
patch
obsolete
>From 75bbf39ec8428613dabdd7955e7f089f59e8c13f Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 16 Mar 2018 11:39:30 +0000 >Subject: [PATCH] Bug 20114: (follow-up) Don't add sort in query cgi > >To test: >1 - Do a search for"*:*" >2 - Try to limit using a facet >3 - Get a search error >4 - Note the URL says kw=*:* >5 - Apply patch >6 - Repeate search >7 - Facet should work >8 - Note URL is better formed >9 - Test with advanced searches as well >--- > Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >index 55b8d25..c156761 100644 >--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >@@ -283,9 +283,6 @@ sub _build_query_query_string { > $uri->query_param_append('q' => $operand) if $operand; > $uri->query_param_append('op' => $operator) if $operator; > } >- if ($query_parts->{sort_by}) { >- $uri->query_param('sort_by' => $query_parts->{sort_by}); >- } > return $uri->query; > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20114
:
71089
| 73025 |
80410