Bugzilla – Attachment 731 Details for
Bug 2553
alphabetize dropdown menus
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Additional patch for drop-down in Existing Requests.
0011-Bug-2553-Additional-patch-for-the-branch-drop-down.patch (text/plain), 3.09 KB, created by
Chris Cormack
on 2009-07-23 01:13:00 UTC
(
hide
)
Description:
Additional patch for drop-down in Existing Requests.
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2009-07-23 01:13:00 UTC
Size:
3.09 KB
patch
obsolete
>From 79b9ca5b343036120584097b3ab4e99a1dcac981 Mon Sep 17 00:00:00 2001 >From: Garry Collum <gcollum@gmail.com> >Date: Wed, 22 Jul 2009 20:50:52 -0400 >Subject: [PATCH] Bug 2553: Additional patch for the branch drop-down in Existing Holds. >Content-Type: text/plain; charset="utf-8" > >Improves previous patch through the use of GetBranchesLoop. Also adds highlighting to the Existing holds table. >--- > .../prog/en/modules/reserve/request.tmpl | 6 +++--- > reserve/request.pl | 10 +--------- > 2 files changed, 4 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl >index a98fefe..ea79fe6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl >@@ -505,7 +505,7 @@ function checkMultiHold() { > <th>Details</th> > </tr> > <!-- TMPL_LOOP Name="reserveloop" --> >- <tr> >+ <!-- TMPL_UNLESS Name="__odd__" --><tr class="highlight"><!-- TMPL_ELSE --><tr><!-- /TMPL_UNLESS --> > <td> > <input type="hidden" name="borrowernumber" value="<!-- TMPL_VAR NAME="borrowernumber" -->" /> > <input type="hidden" name="biblionumber" value="<!-- TMPL_VAR NAME="biblionumber" -->" /> >@@ -539,9 +539,9 @@ function checkMultiHold() { > <select name="pickup"> > <!-- TMPL_LOOP Name="branchloop" --> > <!-- TMPL_IF Name="selected" --> >- <option value="<!-- TMPL_VAR NAME="branch" -->" selected="selected"> >+ <option value="<!-- TMPL_VAR NAME="value" -->" selected="selected"> > <!-- TMPL_ELSE --> >- <option value="<!-- TMPL_VAR NAME="branch" -->"> >+ <option value="<!-- TMPL_VAR NAME="value" -->"> > <!-- /TMPL_IF --> > <!-- TMPL_VAR NAME="branchname" --> > </option> >diff --git a/reserve/request.pl b/reserve/request.pl >index b865c5c..a849d70 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -446,14 +446,6 @@ foreach my $biblionumber (@biblionumbers) { > } > ); > } >- my @branchloop; >- foreach my $br ( sort {$branches->{$a}->{'branchname'} cmp $branches->{$b}->{'branchname'}} keys %$branches ) { >- my %abranch; >- $abranch{'selected'} = ( $br eq $res->{'branchcode'} ); >- $abranch{'branch'} = $br; >- $abranch{'branchname'} = $branches->{$br}->{'branchname'}; >- push( @branchloop, \%abranch ); >- } > > if ( ( $res->{'found'} eq 'W' ) ) { > my $item = $res->{'itemnumber'}; >@@ -497,7 +489,7 @@ foreach my $biblionumber (@biblionumbers) { > $reserve{'ccode'} = $res->{'ccode'}; > $reserve{'barcode'} = $res->{'barcode'}; > $reserve{'priority'} = $res->{'priority'}; >- $reserve{'branchloop'} = \@branchloop; >+ $reserve{'branchloop'} = GetBranchesLoop($res->{'branchcode'}); > $reserve{'optionloop'} = \@optionloop; > > push( @reserveloop, \%reserve ); >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2553
:
721
|
722
|
723
|
724
|
725
|
726
|
727
|
728
|
729
|
730
|
731
|
732
|
733
|
11788
|
11789