Bugzilla – Attachment 73181 Details for
Bug 20067
Wrong display of authorised value for items.materials on staff detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20067: Fix false display of authorised value for materials on staff detail page
Bug-20067-Fix-false-display-of-authorised-value-fo.patch (text/plain), 1.72 KB, created by
Nick Clemens
on 2018-03-23 14:05:43 UTC
(
hide
)
Description:
Bug 20067: Fix false display of authorised value for materials on staff detail page
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2018-03-23 14:05:43 UTC
Size:
1.72 KB
patch
obsolete
>From 050c8b5428ebf21341774114f4a050473512bb4a Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 23 Feb 2018 14:20:17 +0100 >Subject: [PATCH] Bug 20067: Fix false display of authorised value for > materials on staff detail page > >Koha didn't check for a linked authorised value category for >Koha didn't check for a linked authorised value category for >items.materials correctly which led to displaying false information >on the detail page. > >To test: >- before applying the patch: >- make sure sample data and configuration is loaded >- edit any item >- write 2 in the $3 materials specificed >- check the details page normal view - it will display 'restocking' >- apply patch >- check display, it should now show "2" >- link 952$3 (MARC21) to ORDER_CANCELLATION_REASON >- check display again, it should now show 'restocking' > >Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > catalogue/detail.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index f2e8fae..6455604 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -216,7 +216,7 @@ if ( $mss->count ) { > $template->param( itemwithdrawnloop => GetAuthorisedValues( $mss->next->authorised_value) ); > } > >-$mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => { not => undef } }); >+$mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => [ -and => {'!=' => undef }, {'!=' => ''}] }); > my %materials_map; > if ($mss->count) { > my $materials_authvals = GetAuthorisedValues($mss->next->authorised_value); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20067
:
70807
|
70808
|
70809
|
72100
|
72101
|
72120
|
72121
|
72991
|
72992
| 73181 |
73182