From f8edea1a614adaf9b69fd5b4d9cf89c39708b5bb Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 26 Mar 2018 13:13:58 -0300 Subject: [PATCH] Bug 20455: Fix sort patrons by date expired We may need to apply this change for all other occurrences in our codebase. Test plan: - Make sure sample patron data is loaded and you have a patron without a date expired defined - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column => Without this patch you get Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime object --- C4/Utils/DataTables/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm index 8912146e01..1e3f6420a2 100644 --- a/C4/Utils/DataTables/Members.pm +++ b/C4/Utils/DataTables/Members.pm @@ -186,7 +186,7 @@ sub search { if( $patron->{dateexpiry} ) { # FIXME We should not format the date here, do it in template-side instead - $patron->{dateexpiry} = output_pref( { dt => dt_from_string( $patron->{dateexpiry}, 'iso'), dateonly => 1} ); + $patron->{dateexpiry} = output_pref( { dt => scalar dt_from_string( $patron->{dateexpiry}, 'iso'), dateonly => 1} ); } else { $patron->{dateexpiry} = ''; } -- 2.11.0