Bugzilla – Attachment 73466 Details for
Bug 20392
Multiple biblio holding does not work when patron is not set
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20392: Fix handling multi hold when not patron set
Bug-20392-Fix-handling-multi-hold-when-not-patron-.patch (text/plain), 4.83 KB, created by
Kyle M Hall
on 2018-03-30 11:15:45 UTC
(
hide
)
Description:
Bug 20392: Fix handling multi hold when not patron set
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2018-03-30 11:15:45 UTC
Size:
4.83 KB
patch
obsolete
>From 17f0888c072e07b644dad66e4014408ac14dcf3e Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Tue, 13 Mar 2018 13:15:48 +0000 >Subject: [PATCH] Bug 20392: Fix handling multi hold when not patron set > >Test plan: >0) Do not apply the patch >1) Set the system preference DisplayMultiPlaceHold to enable >2) Search in staff client catalogue >3) On results page check more then one result and click on Place hold >button at the top of the page >4) Search for patron, but don't be to specific, you need to have more >then one result >5) Click on one of the found patron >6) Now you are going to confirm a hold, but only for one record! >7) Apply the patch >8) Repeat 2-5 and confirm that now it is working as expected ( place > hold for multiple records) > >Signed-off-by: delaye <stephane.delaye@biblibre.com> >Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/includes/circ-patron-search-results.inc | 9 +++++++-- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 7 ++++--- > 2 files changed, 11 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc >index 8d8fcc65f4..c99e3b5bd7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc >@@ -17,8 +17,13 @@ > <tr class="clickable" data-url="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrower.borrowernumber %]"> > <td><a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrower.borrowernumber %]">[% borrower.surname %], [% borrower.firstname %]</a></td> > [% ELSE %] >- <tr class="clickable" data-url="/cgi-bin/koha/reserve/request.pl?borrowernumber=[% borrower.borrowernumber %]&biblionumber=[% biblionumber %]"> >- <td><a href="/cgi-bin/koha/reserve/request.pl?borrowernumber=[% borrower.borrowernumber %]&biblionumber=[% biblionumber %]">[% borrower.surname %], [% borrower.firstname %]</a></td> >+ [% IF ( multi_hold) %] >+ <tr class="clickable" data-url="/cgi-bin/koha/reserve/request.pl?borrowernumber=[% borrower.borrowernumber %]&biblionumbers=[% biblionumbers %]&multi_hold=1"> >+ <td><a href="/cgi-bin/koha/reserve/request.pl?borrowernumber=[% borrower.borrowernumber %]&biblionumbers=[% biblionumbers %]&multi_hold=1">[% borrower.surname %], [% borrower.firstname %]</a></td> >+ [% ELSE %] >+ <tr class="clickable" data-url="/cgi-bin/koha/reserve/request.pl?borrowernumber=[% borrower.borrowernumber %]&biblionumber=[% biblionumber %]"> >+ <td><a href="/cgi-bin/koha/reserve/request.pl?borrowernumber=[% borrower.borrowernumber %]&biblionumber=[% biblionumber %]">[% borrower.surname %], [% borrower.firstname %]</a></td> >+ [% END %] > [% END %] > <td>[% borrower.cardnumber %]</td> > <td>[% borrower.dateofbirth | $KohaDates %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 4a1d6a31e8..7af7427234 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -269,7 +269,7 @@ function checkMultiHold() { > [% IF ( messageborrower ) %] > <div class="dialog alert"><h3>Patron not found</h3><p>No patron with this name, please, try another</p> </div> > [% END %] >- <form id="holds_patronsearch" action="request.pl?biblionumber=[% biblionumber %]" method="post"> >+ <form id="holds_patronsearch" action="request.pl" method="post"> > <fieldset id="circ_holds_selectborrower" class="brief"> > > [% UNLESS borrowers %] >@@ -277,16 +277,17 @@ function checkMultiHold() { > <div class="hint">Enter patron card number or partial name:</div> > <input type="text" size="40" id="patron" class="focus" name="findborrower" /> > <input type="submit" value="Search" /> >- <input type="hidden" name="biblionumber" value="[% biblionumber %]" /> > </fieldset> > [% ELSE %] > [% INCLUDE 'circ-patron-search-results.inc' destination = "holds" %] > </fieldset> >- > [% END %] >+ > [% IF ( multi_hold ) %] > <input type="hidden" name="multi_hold" value="[% multi_hold %]"/> > <input type="hidden" name="biblionumbers" value="[% biblionumbers %]"/> >+ [% ELSE %] >+ <input type="hidden" name="biblionumber" value="[% biblionumber %]"/> > [% END %] > </form> > [% ELSIF NOT noitems %] >-- >2.14.3 (Apple Git-98)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20392
:
72814
|
72856
|
73060
| 73466