Bugzilla – Attachment 7364 Details for
Bug 6875
de-nesting C4 packages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED_QA][PATCH 10]Bug 6875 de-nesting C4::Heading
Bug-6875-de-nesting-C4Heading.patch (text/plain), 1.88 KB, created by
Jared Camins-Esakov
on 2012-01-28 14:26:45 UTC
(
hide
)
Description:
[PASSED_QA][PATCH 10]Bug 6875 de-nesting C4::Heading
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-01-28 14:26:45 UTC
Size:
1.88 KB
patch
obsolete
>From ce8ed82b22a037f298f1b6db229073862b37f403 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Fri, 16 Sep 2011 19:38:06 +0200 >Subject: [PATCH] Bug 6875 de-nesting C4::Heading >Content-Type: text/plain; charset="UTF-8" > >C4::Search is needed only in authorities sub, moving it here and switching to >require > >Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> >Corrected call to SimpleSearch in both subs where it is used. Additional >performance improvements are included in bug 7284. 28 Jan 2012 >--- > C4/Heading.pm | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Heading.pm b/C4/Heading.pm >index ba9d23f..d9e13d4 100644 >--- a/C4/Heading.pm >+++ b/C4/Heading.pm >@@ -23,7 +23,6 @@ use MARC::Record; > use MARC::Field; > use C4::Context; > use C4::Heading::MARC21; >-use C4::Search; > use Carp; > > our $VERSION = 3.00; >@@ -109,7 +108,8 @@ sub authorities { > my $self = shift; > my $query = qq(Match-heading,do-not-truncate,ext="$self->{'search_form'}"); > $query .= $self->_query_limiters(); >- my ($error, $results, $total_hits) = SimpleSearch( $query, undef, undef, [ "authorityserver" ] ); >+ require C4::Search; >+ my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, undef, undef, [ "authorityserver" ] ); > if (defined $error) { > carp "Error:$error from search $query"; > } >@@ -129,7 +129,8 @@ sub preferred_authorities { > my $self = shift; > my $query = "Match-heading-see-from,do-not-truncate,ext='$self->{'search_form'}'"; > $query .= $self->_query_limiters(); >- my ($error, $results, $total_hits) = SimpleSearch( $query, undef, undef, [ "authorityserver" ] ); >+ require C4::Search; >+ my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, undef, undef, [ "authorityserver" ] ); > if (defined $error) { > carp "Error:$error from search $query"; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6875
:
5442
|
5443
|
5496
|
5497
|
5498
|
5499
|
5500
|
5501
|
5502
|
5503
|
5504
|
5505
|
5506
|
5507
|
5508
|
5509
|
5510
|
5511
|
5512
|
7359
|
7360
|
7361
|
7362
|
7363
|
7364
|
7365
|
7652
|
7654
|
7655
|
7656
|
7657
|
7658
|
7770
|
7771
|
7808
|
7844
|
8095
|
8133
|
8134
|
8135