Bugzilla – Attachment 73733 Details for
Bug 18816
Make CataloguingLog work in production by preventing circulation from spamming the log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18816: (QA follow-up) Fix Circulation.t
Bug-18816-QA-follow-up-Fix-Circulationt.patch (text/plain), 1.32 KB, created by
Marcel de Rooy
on 2018-04-06 06:11:03 UTC
(
hide
)
Description:
Bug 18816: (QA follow-up) Fix Circulation.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-04-06 06:11:03 UTC
Size:
1.32 KB
patch
obsolete
>From a25aa49d725fd22ec590d9fad89cbc096e48bd58 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 6 Apr 2018 08:05:58 +0200 >Subject: [PATCH] Bug 18816: (QA follow-up) Fix Circulation.t >Content-Type: text/plain; charset=utf-8 > >Resolve: >ok 33 - Can renew, item is marked not for loan, hold does not block >Can't use string ("1") as a HASH ref while "strict refs" in use at /usr/share/koha/devclone/C4/Items.pm line 557. > >Trivial fix. Remove fourth parameter. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Circulation.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 0e82019..d9c614b 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -418,7 +418,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > ModItem({ notforloan => 1 }, $biblionumber, $itemnumber); > ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1); > is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block'); >- ModItem({ notforloan => 0, itype => $itemtype }, $biblionumber, $itemnumber,1); >+ ModItem({ notforloan => 0, itype => $itemtype }, $biblionumber, $itemnumber); > > # FIXME: Add more for itemtype not for loan etc. > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18816
:
64383
|
64393
|
65711
|
65712
|
68600
|
68647
|
73154
|
73155
|
73169
|
73170
|
73171
|
73729
|
73730
|
73731
|
73732
| 73733