Bugzilla – Attachment 73734 Details for
Bug 11512
Only allow to override maximum number of holds from staff as other overrides would never be filled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11512 - Forced holds that violate issuing rules will never be filled
Bug-11512---Forced-holds-that-violate-issuing-rule.patch (text/plain), 1.61 KB, created by
Marcel de Rooy
on 2018-04-06 06:27:33 UTC
(
hide
)
Description:
Bug 11512 - Forced holds that violate issuing rules will never be filled
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-04-06 06:27:33 UTC
Size:
1.61 KB
patch
obsolete
>From e7e12b8ff16bcbb381fa36edc49345d931f02b50 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 26 Oct 2017 07:40:04 -0400 >Subject: [PATCH] Bug 11512 - Forced holds that violate issuing rules will > never be filled >Content-Type: text/plain; charset=utf-8 > >Currently in Koha, if you choose to force a hold from the staff side that would contravened the current issuing rules, that hold will never be filled, as it is always skipped over by CheckReserves. > >This patch disallows overrideing except for tooManyReserves which are the only overridden holds that will be trapped. > >Test Plan: >1) Apply this patch >2) Attempt to override hold placement, only placements where the patron has too many holds already should be allowed > >Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index b67769a..2902de0 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -478,7 +478,7 @@ foreach my $biblionumber (@biblionumbers) { > > push( @available_itemtypes, $item->{itype} ); > } >- elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) { >+ elsif ( $can_item_be_reserved eq 'tooManyReserves' && C4::Context->preference('AllowHoldPolicyOverride') ) { > # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules > $item->{override} = 1; > $num_override++; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11512
:
68594
|
68595
|
72689
|
73172
|
73173
| 73734 |
73735