Bugzilla – Attachment 73758 Details for
Bug 12123
HTML notices can break the notice viewer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12123 - HTML notices can break the notice viewer
Bug-12123---HTML-notices-can-break-the-notice-view.patch (text/plain), 1.89 KB, created by
Marcel de Rooy
on 2018-04-06 09:40:01 UTC
(
hide
)
Description:
Bug 12123 - HTML notices can break the notice viewer
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-04-06 09:40:01 UTC
Size:
1.89 KB
patch
obsolete
>From a99f0c6e702d1d35343ab9a72d6312fe293247ba Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 22 Apr 2014 06:55:22 -0700 >Subject: [PATCH] Bug 12123 - HTML notices can break the notice viewer >Content-Type: text/plain; charset=utf-8 > >Depending on the content of an html notice, it can cause the notice to >either not be collapsible, be uncollapsible, or to be permanently >collapsed. > >Test Plan: >1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : ><p>The following items have been checked out:</p> > >---- ><blockquote> <<biblio.title>> </blockquote> >---- > ><p>Thank you for visiting the <<branches.branchname>> of HMCPL.</p> >2) Check out some items to a patron >3) View the patrn's notices >4) Note the notice viewer is broken ( message is not collapsed, and > con't be collapsed ). >5) Apply this patch >6) Reload the page >7) Note the notice viewer is no longer broken > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >I followed the test plan successfully. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >index fecf201..0315dcd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >@@ -42,7 +42,7 @@ > <td> > <a class="notice-title" data-noticeid="[% QUEUED_MESSAGE.message_id %]" href="#">[% QUEUED_MESSAGE.subject %]</a> > <div id="notice[% QUEUED_MESSAGE.message_id %]" class="notice"> >- [% QUEUED_MESSAGE.content FILTER html_line_break %] >+ <iframe srcdoc="[% QUEUED_MESSAGE.content FILTER html_line_break FILTER html %]"></iframe> > </div> > </td> > <td> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12123
:
27402
|
27403
|
33863
|
33876
|
33882
|
33885
|
33888
|
33950
|
33976
|
73650
| 73758 |
74113
|
74169