Bugzilla – Attachment 73922 Details for
Bug 18625
Update borrower last seen from SIP
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18625: (QA follow-up) Simplify update_lastseen
Bug-18625-QA-follow-up-Simplify-updatelastseen.patch (text/plain), 1.06 KB, created by
Kyle M Hall
on 2018-04-10 11:21:45 UTC
(
hide
)
Description:
Bug 18625: (QA follow-up) Simplify update_lastseen
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2018-04-10 11:21:45 UTC
Size:
1.06 KB
patch
obsolete
>From a6e85b840029962a06bd92d8c591a93cc661aa65 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 11 Oct 2017 14:41:17 +0200 >Subject: [PATCH] Bug 18625: (QA follow-up) Simplify update_lastseen > >No need to check the pref. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SIP/ILS/Patron.pm | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 81036c9cce..23c576493f 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -452,12 +452,8 @@ sub charge_denied { > > sub update_lastseen { > my $self = shift; >- my $p; >- if (C4::Context->preference('TrackLastPatronActivity') >- && $p = Koha::Patrons->find({ borrowernumber => $self->{borrowernumber} })) { >- $p->track_login; >- } >- return; >+ my $kohaobj = Koha::Patrons->find( $self->{borrowernumber} ); >+ $kohaobj->track_login if $kohaobj; # track_login checks the pref > } > > sub _get_address { >-- >2.15.1 (Apple Git-101)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18625
:
63533
|
67953
|
67954
|
68650
|
68651
|
68652
|
72557
|
72558
|
73920
|
73921
| 73922