Bugzilla – Attachment 73957 Details for
Bug 20556
Marking ILL request as complete results in "Internal server error"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug [20556] - [Marking ILL request as complete..]
Bug-20556---Marking-ILL-request-as-complete.patch (text/plain), 1.25 KB, created by
Andrew Isherwood
on 2018-04-10 15:59:56 UTC
(
hide
)
Description:
Bug [20556] - [Marking ILL request as complete..]
Filename:
MIME Type:
Creator:
Andrew Isherwood
Created:
2018-04-10 15:59:56 UTC
Size:
1.25 KB
patch
obsolete
>From daf2332963568c94b4271cbf74e25dd3016c2657 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Tue, 10 Apr 2018 16:50:56 +0100 >Subject: [PATCH] Bug [20556] - [Marking ILL request as complete..] > >When marking a request as complete, the status is updated internally >then the user to redirected to the view of the request. > >Although the redirect header is sent, there is no exit to indicate that >the program flow should stop. As a result, an attempt is made to render >the template, which fails. > >This patch simply adds the missing exit. > >TEST PLAN >--------- > >- Create an ILL request >- "Manage request" > "Confirm request" >- "Mark completed" >- TEST: Ensure that no error is written to the error log upon clicking >"Mark completed" >--- > ill/ill-requests.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl >index 029fa49eea..47cfc97050 100755 >--- a/ill/ill-requests.pl >+++ b/ill/ill-requests.pl >@@ -264,6 +264,7 @@ sub handle_commit_maybe { > '/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id='. > $request->id > ); >+ exit; > } else { > # Redirect to a requests list view > redirect_to_list(); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20556
:
73957
|
74041
|
74598