View | Details | Raw Unified | Return to bug 18677
Collapse All | Expand All

(-)a/C4/Accounts.pm (-1 / +2 lines)
Lines 134-140 FIXME : if no replacement price, borrower just doesn't get charged? Link Here
134
134
135
sub chargelostitem{
135
sub chargelostitem{
136
    my $dbh = C4::Context->dbh();
136
    my $dbh = C4::Context->dbh();
137
    my ($borrowernumber, $itemnumber, $amount, $description) = @_;
137
    my ($borrowernumber, $itemnumber, $issue_id, $amount, $description) = @_;
138
    my $itype = Koha::ItemTypes->find({ itemtype => Koha::Items->find($itemnumber)->effective_itemtype() });
138
    my $itype = Koha::ItemTypes->find({ itemtype => Koha::Items->find($itemnumber)->effective_itemtype() });
139
    my $replacementprice = $amount;
139
    my $replacementprice = $amount;
140
    my $defaultreplacecost = $itype->defaultreplacecost;
140
    my $defaultreplacecost = $itype->defaultreplacecost;
Lines 162-167 sub chargelostitem{ Link Here
162
            my $accountline = Koha::Account::Line->new(
162
            my $accountline = Koha::Account::Line->new(
163
                {
163
                {
164
                    borrowernumber    => $borrowernumber,
164
                    borrowernumber    => $borrowernumber,
165
                    issue_id          => $issue_id,
165
                    accountno         => getnextacctno($borrowernumber),
166
                    accountno         => getnextacctno($borrowernumber),
166
                    date              => \'NOW()',
167
                    date              => \'NOW()',
167
                    amount            => $processfee,
168
                    amount            => $processfee,
(-)a/C4/Circulation.pm (-1 / +2 lines)
Lines 3633-3639 sub LostItem{ Link Here
3633
            defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!";  # zero is OK, check defined
3633
            defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!";  # zero is OK, check defined
3634
        }
3634
        }
3635
        if (C4::Context->preference('WhenLostChargeReplacementFee')){
3635
        if (C4::Context->preference('WhenLostChargeReplacementFee')){
3636
            C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'}");
3636
            my $checkout = Koha::Checkouts->find({ itemnumber => $itemnumber });
3637
            C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $checkout->id, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'}");
3637
            #FIXME : Should probably have a way to distinguish this from an item that really was returned.
3638
            #FIXME : Should probably have a way to distinguish this from an item that really was returned.
3638
            #warn " $issues->{'borrowernumber'}  /  $itemnumber ";
3639
            #warn " $issues->{'borrowernumber'}  /  $itemnumber ";
3639
        }
3640
        }
(-)a/t/db_dependent/Accounts.t (-20 / +31 lines)
Lines 489-495 subtest 'balance' => sub { Link Here
489
};
489
};
490
490
491
subtest "Koha::Account::chargelostitem tests" => sub {
491
subtest "Koha::Account::chargelostitem tests" => sub {
492
    plan tests => 32;
492
    plan tests => 39;
493
493
494
    my $lostfine;
494
    my $lostfine;
495
    my $procfee;
495
    my $procfee;
Lines 519-630 subtest "Koha::Account::chargelostitem tests" => sub { Link Here
519
    my $cli_itemnumber2 = $builder->build({ source => 'Item', value => { itype => $itype_replace_no_fee->{itemtype} } })->{'itemnumber'};
519
    my $cli_itemnumber2 = $builder->build({ source => 'Item', value => { itype => $itype_replace_no_fee->{itemtype} } })->{'itemnumber'};
520
    my $cli_itemnumber3 = $builder->build({ source => 'Item', value => { itype => $itype_no_replace_fee->{itemtype} } })->{'itemnumber'};
520
    my $cli_itemnumber3 = $builder->build({ source => 'Item', value => { itype => $itype_no_replace_fee->{itemtype} } })->{'itemnumber'};
521
    my $cli_itemnumber4 = $builder->build({ source => 'Item', value => { itype => $itype_replace_fee->{itemtype} } })->{'itemnumber'};
521
    my $cli_itemnumber4 = $builder->build({ source => 'Item', value => { itype => $itype_replace_fee->{itemtype} } })->{'itemnumber'};
522
523
    my $cli_issue_id_1 = $builder->build({ source => 'Issue', value => { borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1 } })->{issue_id};
524
    my $cli_issue_id_2 = $builder->build({ source => 'Issue', value => { borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2 } })->{issue_id};
525
    my $cli_issue_id_3 = $builder->build({ source => 'Issue', value => { borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3 } })->{issue_id};
526
    my $cli_issue_id_4 = $builder->build({ source => 'Issue', value => { borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4 } })->{issue_id};
527
522
    my $duck = Koha::Items->find({itemnumber=>$cli_itemnumber1});
528
    my $duck = Koha::Items->find({itemnumber=>$cli_itemnumber1});
523
529
524
    t::lib::Mocks::mock_preference('item-level_itypes', '1');
530
    t::lib::Mocks::mock_preference('item-level_itypes', '1');
525
    t::lib::Mocks::mock_preference('useDefaultReplacementCost', '0');
531
    t::lib::Mocks::mock_preference('useDefaultReplacementCost', '0');
526
532
527
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 0, "Perdedor");
533
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, $cli_issue_id_1, 0, "Perdedor");
528
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
534
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
529
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
530
    ok( !$lostfine, "No lost fine if no replacementcost or default when pref off");
535
    ok( !$lostfine, "No lost fine if no replacementcost or default when pref off");
531
    ok( !$procfee,  "No processing fee if no processing fee");
536
    ok( !$procfee,  "No processing fee if no processing fee");
532
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 6.12, "Perdedor");
537
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, $cli_issue_id_1, 6.12, "Perdedor");
533
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
538
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
534
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
539
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
535
    ok( $lostfine->amount == 6.12, "Lost fine equals replacementcost when pref off and no default set");
540
    ok( $lostfine->amount == 6.12, "Lost fine equals replacementcost when pref off and no default set");
536
    ok( !$procfee,  "No processing fee if no processing fee");
541
    ok( !$procfee,  "No processing fee if no processing fee");
537
    $lostfine->delete();
542
    $lostfine->delete();
538
543
539
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 0, "Perdedor");
544
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, $cli_issue_id_2, 0, "Perdedor");
540
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
545
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
541
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
546
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
542
    ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
547
    ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
543
    ok( !$procfee,  "No processing fee if no processing fee");
548
    ok( !$procfee,  "No processing fee if no processing fee");
544
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 6.12, "Perdedor");
549
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, $cli_issue_id_2, 6.12, "Perdedor");
545
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
550
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
546
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
551
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
547
    ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
552
    ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
548
    ok( !$procfee,  "No processing fee if no processing fee");
553
    ok( !$procfee,  "No processing fee if no processing fee");
549
    $lostfine->delete();
554
    $lostfine->delete();
550
555
551
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 0, "Perdedor");
556
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, $cli_issue_id_3, 0, "Perdedor");
552
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
557
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
553
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
558
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
554
    ok( !$lostfine, "No lost fine if no replacementcost and no default set when pref off");
559
    ok( !$lostfine, "No lost fine if no replacementcost and no default set when pref off");
555
    ok( $procfee->amount == 8.16,  "Processing fee if processing fee");
560
    ok( $procfee->amount == 8.16,  "Processing fee if processing fee");
561
    is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
556
    $procfee->delete();
562
    $procfee->delete();
557
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 6.12, "Perdedor");
563
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, $cli_issue_id_3, 6.12, "Perdedor");
558
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
564
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
559
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
565
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
560
    ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and no default set");
566
    ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and no default set");
561
    ok( $procfee->amount == 8.16,  "Processing fee if processing fee");
567
    ok( $procfee->amount == 8.16,  "Processing fee if processing fee");
568
    is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
562
    $lostfine->delete();
569
    $lostfine->delete();
563
    $procfee->delete();
570
    $procfee->delete();
564
571
565
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
572
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, $cli_issue_id_4, 0, "Perdedor");
566
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
573
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
567
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
574
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
568
    ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
575
    ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
569
    ok( $procfee->amount == 2.04,  "Processing fee if processing fee");
576
    ok( $procfee->amount == 2.04,  "Processing fee if processing fee");
577
    is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
570
    $procfee->delete();
578
    $procfee->delete();
571
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 6.12, "Perdedor");
579
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, $cli_issue_id_4, 6.12, "Perdedor");
572
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
580
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
573
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
581
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
574
    ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
582
    ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
575
    ok( $procfee->amount == 2.04,  "Processing fee if processing fee");
583
    ok( $procfee->amount == 2.04,  "Processing fee if processing fee");
584
    is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
576
    $lostfine->delete();
585
    $lostfine->delete();
577
    $procfee->delete();
586
    $procfee->delete();
578
587
579
    t::lib::Mocks::mock_preference('useDefaultReplacementCost', '1');
588
    t::lib::Mocks::mock_preference('useDefaultReplacementCost', '1');
580
589
581
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 0, "Perdedor");
590
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, $cli_issue_id_1, 0, "Perdedor");
582
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
591
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
583
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
592
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
584
    ok( !$lostfine, "No lost fine if no replacementcost or default when pref on");
593
    ok( !$lostfine, "No lost fine if no replacementcost or default when pref on");
585
    ok( !$procfee,  "No processing fee if no processing fee");
594
    ok( !$procfee,  "No processing fee if no processing fee");
586
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 6.12, "Perdedor");
595
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, $cli_issue_id_1, 6.12, "Perdedor");
587
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
596
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
588
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
597
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
589
    is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
598
    is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
590
    ok( !$procfee,  "No processing fee if no processing fee");
599
    ok( !$procfee,  "No processing fee if no processing fee");
591
600
592
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 0, "Perdedor");
601
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, $cli_issue_id_2, 0, "Perdedor");
593
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
602
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
594
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
603
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
595
    is( $lostfine->amount(), "16.320000", "Lost fine is default if no replacementcost but default set when pref on");
604
    is( $lostfine->amount(), "16.320000", "Lost fine is default if no replacementcost but default set when pref on");
596
    ok( !$procfee,  "No processing fee if no processing fee");
605
    ok( !$procfee,  "No processing fee if no processing fee");
597
    $lostfine->delete();
606
    $lostfine->delete();
598
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 6.12, "Perdedor");
607
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, $cli_issue_id_2, 6.12, "Perdedor");
599
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
608
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
600
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
609
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
601
    is( $lostfine->amount, "6.120000" , "Lost fine equals replacementcost when pref on and default set");
602
    ok( !$procfee,  "No processing fee if no processing fee");
610
    ok( !$procfee,  "No processing fee if no processing fee");
603
611
604
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 0, "Perdedor");
612
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, $cli_issue_id_3, 0, "Perdedor");
605
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
613
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
606
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
614
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
607
    ok( !$lostfine, "No lost fine if no replacementcost and default not set when pref on");
615
    ok( !$lostfine, "No lost fine if no replacementcost and default not set when pref on");
608
    is( $procfee->amount, "8.160000",  "Processing fee if processing fee");
616
    is( $procfee->amount, "8.160000",  "Processing fee if processing fee");
617
    is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
609
    $procfee->delete();
618
    $procfee->delete();
610
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 6.12, "Perdedor");
619
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, $cli_issue_id_3, 6.12, "Perdedor");
611
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
620
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
612
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
621
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
613
    is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
622
    is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
614
    is( $procfee->amount, "8.160000",  "Processing fee if processing fee");
623
    is( $procfee->amount, "8.160000",  "Processing fee if processing fee");
624
    is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
615
625
616
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
626
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, $cli_issue_id_4, 0, "Perdedor");
617
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
627
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
618
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
628
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
619
    is( $lostfine->amount, "4.080000", "Lost fine is default if no replacementcost but default set when pref on");
629
    is( $lostfine->amount, "4.080000", "Lost fine is default if no replacementcost but default set when pref on");
620
    is( $procfee->amount, "2.040000",  "Processing fee if processing fee");
630
    is( $procfee->amount, "2.040000",  "Processing fee if processing fee");
631
    is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
621
    $lostfine->delete();
632
    $lostfine->delete();
622
    $procfee->delete();
633
    $procfee->delete();
623
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 6.12, "Perdedor");
634
    C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, $cli_issue_id_4, 6.12, "Perdedor");
624
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
635
    $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
625
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
636
    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
626
    is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and default set");
637
    is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and default set");
627
    is( $procfee->amount, "2.040000",  "Processing fee if processing fee");
638
    is( $procfee->amount, "2.040000",  "Processing fee if processing fee");
639
    is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
628
};
640
};
629
641
630
subtest "Koha::Account::non_issues_charges tests" => sub {
642
subtest "Koha::Account::non_issues_charges tests" => sub {
631
- 

Return to bug 18677