Bugzilla – Attachment 74108 Details for
Bug 20499
Checkout of bad barcode: Internal Server Error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20499: Fix the Internal Server Error
Bug-20499-Fix-the-Internal-Server-Error.patch (text/plain), 1.65 KB, created by
Jonathan Druart
on 2018-04-12 15:32:03 UTC
(
hide
)
Description:
Bug 20499: Fix the Internal Server Error
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-04-12 15:32:03 UTC
Size:
1.65 KB
patch
obsolete
>From 9fa22046a81d9e467293466ed0ebe93346909ffc Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 29 Mar 2018 18:47:25 +0000 >Subject: [PATCH] Bug 20499: Fix the Internal Server Error > >TEST PLAN >--------- >See comment #1 > >Applying the test without the patch: messy. >Applyin both patches: smooth. >Run koha qa test tools > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Circulation.pm | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 67ee4e56fe..369d4a2f98 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -669,6 +669,12 @@ sub CanBookBeIssued { > my $override_high_holds = $params->{override_high_holds} || 0; > > my $item = GetItem(undef, $barcode ); >+ # MANDATORY CHECKS - unless item exists, nothing else matters >+ unless ( $item->{barcode} ) { >+ $issuingimpossible{UNKNOWN_BARCODE} = 1; >+ } >+ return ( \%issuingimpossible, \%needsconfirmation ) if %issuingimpossible; >+ > my $issue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } ); > my $biblio = Koha::Biblios->find( $item->{biblionumber} ); > my $biblioitem = $biblio->biblioitem; >@@ -676,12 +682,6 @@ sub CanBookBeIssued { > my $dbh = C4::Context->dbh; > my $patron_unblessed = $patron->unblessed; > >- # MANDATORY CHECKS - unless item exists, nothing else matters >- unless ( $item->{barcode} ) { >- $issuingimpossible{UNKNOWN_BARCODE} = 1; >- } >- return ( \%issuingimpossible, \%needsconfirmation ) if %issuingimpossible; >- > # > # DUE DATE is OK ? -- should already have checked. > # >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20499
:
73439
|
73440
|
73442
|
74107
|
74108
|
74109
|
74144
|
74145
|
74146