Bugzilla – Attachment 74144 Details for
Bug 20499
Checkout of bad barcode: Internal Server Error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20499: Unit Test to prove the problem
Bug-20499-Unit-Test-to-prove-the-problem.patch (text/plain), 1.77 KB, created by
Marcel de Rooy
on 2018-04-13 08:16:00 UTC
(
hide
)
Description:
Bug 20499: Unit Test to prove the problem
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-04-13 08:16:00 UTC
Size:
1.77 KB
patch
obsolete
>From 154990bfc8d3b099ef4081db6ecefa5d29862fe4 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 29 Mar 2018 18:44:32 +0000 >Subject: [PATCH] Bug 20499: Unit Test to prove the problem >Content-Type: text/plain; charset=utf-8 > >TEST PLAN >--------- >1) apply this patch >2) prove t/db_dependent/Circulation.t > -- horrible death. >3) apply next path >4) prove t/db_dependent/Circulation.t > -- passes. >5) run koha qa test tools > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Circulation.t | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 497df64..bc14b53 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -1193,7 +1193,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > } > > subtest 'CanBookBeIssued & AllowReturnToBranch' => sub { >- plan tests => 23; >+ plan tests => 24; > > my $homebranch = $builder->build( { source => 'Branch' } ); > my $holdingbranch = $builder->build( { source => 'Branch' } ); >@@ -1225,6 +1225,10 @@ subtest 'CanBookBeIssued & AllowReturnToBranch' => sub { > > # AllowReturnToBranch == anywhere > t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' ); >+ ## Test that unknown barcodes don't generate internal server errors >+ set_userenv($homebranch); >+ ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' ); >+ ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' ); > ## Can be issued from homebranch > set_userenv($homebranch); > ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20499
:
73439
|
73440
|
73442
|
74107
|
74108
|
74109
| 74144 |
74145
|
74146