Bugzilla – Attachment 74359 Details for
Bug 17674
Allow UI to delete serials issues in batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17674: Remove delete related item checkbox when no items is available
Bug-17674-Remove-delete-related-item-checkbox-when.patch (text/plain), 2.00 KB, created by
Roch D'Amour
on 2018-04-17 15:14:27 UTC
(
hide
)
Description:
Bug 17674: Remove delete related item checkbox when no items is available
Filename:
MIME Type:
Creator:
Roch D'Amour
Created:
2018-04-17 15:14:27 UTC
Size:
2.00 KB
patch
obsolete
>From a8e3fd2433f06b3cdb95ca33f25e8c37bcff8692 Mon Sep 17 00:00:00 2001 >From: Roch D'Amour <roch.damour@inlibro.com> >Date: Tue, 17 Apr 2018 10:59:18 -0400 >Subject: [PATCH] Bug 17674: Remove delete related item checkbox when no items > is available > >When the number of items available is 0, the confirmation dialog still ask is you >also want to delete related items. This patch remove the checkbox in the confirmation dialog >when the number of related items is 0. > >To test: >- Try to delete some serials that has items available, the confirmation dialog does not ask >if you want to delete related items since there are none. >- Try to delete some serials which has items avaible. The confirmation dialog should show a checkbox >and ask if you want to delete related items >--- > .../intranet-tmpl/prog/en/modules/serials/serials-collection.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index 055d079..29aef38 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -35,9 +35,11 @@ > <h3>Are you sure you want to delete? <b>[% serialnumber %]</b> serial(s) will be deleted</h3> > <form action="/cgi-bin/koha/serials/serials-collection.pl/#"> > <h5>Number of items available: <b>[% countitems %]</b></h5> >- <p> >- <label>Delete associated items? <input type="checkbox" name="delitems" value="Yes" />Yes</label> >- </p> >+ [% IF $countitems > 0 %] >+ <p> >+ <label>Delete associated items? <input type="checkbox" name="delitems" value="Yes" />Yes</label> >+ </p> >+ [% END %] > > <input type="hidden" name="subscriptionid" value="[% subscriptionid %]" /> > <input type="hidden" name="serialsid" value="[% serialsid %]" /> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17674
:
57731
|
58262
|
58263
|
58264
|
60925
|
61314
|
61315
|
61316
|
66565
|
69007
|
69010
|
69011
|
69013
|
69976
|
69977
|
69978
|
69979
|
71865
|
71866
|
71867
|
71868
|
71869
|
72985
|
73032
|
73035
|
73036
|
73037
|
73038
|
73039
|
73040
|
74318
|
74359
|
74472
|
75643
|
75644
|
75645
|
75646
|
75647
|
75648
|
75649
|
77745
|
77746
|
77747
|
77748
|
77749
|
77750
|
77751
|
77861
|
77862
|
77863
|
77864
|
77865
|
77866
|
77867
|
77868
|
79415
|
79420
|
79421
|
79422
|
79423
|
79424
|
79425
|
79426
|
79427
|
79428
|
79453
|
79454
|
79455
|
79456
|
79457
|
79458
|
79459
|
79460
|
80859
|
80944
|
80955
|
82237
|
86689
|
95474
|
99434
|
99944
|
99945
|
100906
|
100907