From c056c5d6d7173b7712a5322d834023313b547996 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 21 Oct 2011 10:19:30 -0400 Subject: [PATCH] Fix for Bug 7080 - Clean up interface on fine payment screens Content-Type: text/plain; charset="utf-8" - Move some content out of table cells - Improve table markup with , , and - Improve breadcrumb specificity on paycollect.pl - Add clearer messages for different actions (Pay selected fines, pay an individual fine, etc. - Add client-side warning to pay.pl when writing-off all - Correcting terminology: When a verb, "write off," when a noun: "Writeoff." --- .../intranet-tmpl/prog/en/modules/members/pay.tt | 43 ++++-- .../prog/en/modules/members/paycollect.tt | 155 +++++++++----------- 2 files changed, 98 insertions(+), 100 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt index 8b0a545..67547d3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt @@ -1,19 +1,23 @@ [% INCLUDE 'doc-head-open.inc' %] Koha › Patrons › Pay Fines for [% borrower.firstname %] [% borrower.surname %] [% INCLUDE 'doc-head-close.inc' %] + [% INCLUDE 'header.inc' %] [% INCLUDE 'patron-search.inc' %] - -
@@ -38,6 +42,7 @@ function confirmWriteoffAll() { + @@ -48,14 +53,21 @@ function confirmWriteoffAll() { - + + + + + + + + [% FOREACH account_grp IN accounts %] [% FOREACH line IN account_grp.accountlines %] [% END %] [% END %] - - - - +
Fines & Charges SelAmount Amount Outstanding
Total Due:[% total | format('%.2f') %]
[% IF ( line.amountoutstanding > 0 ) %] - + [% END %] @@ -89,15 +101,12 @@ function confirmWriteoffAll() {
Total Due:[% total | format('%.2f') %]
- - - + + + Cancel
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt index ba18215..b504467 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ -57,7 +57,7 @@ function moneyFormat(textObj) { [% INCLUDE 'header.inc' %] [% INCLUDE 'patron-search.inc' %] - +
@@ -103,50 +103,50 @@ function moneyFormat(textObj) { + +
+ Pay an individual fine - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + +
DescriptionAccount TypeNotify idLevelAmountAmount Outstanding
- [% description %] [% title %] - [% accounttype %][% notify_id %][% notify_level %][% amount | format('%.2f') %][% amountoutstanding | format('%.2f') %]
Total Amount Payable : [% amountoutstanding | format('%.2f') %]
Collect From Patron: +
DescriptionAccount TypeNotify idLevelAmountAmount Outstanding
Total amount payable:[% amountoutstanding | format('%.2f') %]
+ [% description %] [% title %] + [% accounttype %][% notify_id %][% notify_level %][% amount | format('%.2f') %][% amountoutstanding | format('%.2f') %]
+ +
    + +
  1. + - - - - - - - Cancel - - +
  2. +
+
- + [% ELSIF ( writeoff_individual ) %]
+
+ Write off an individual fine @@ -159,33 +159,27 @@ function moneyFormat(textObj) { - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + +
DescriptionAccount TypeNotify idLevelAmountAmount Outstanding
[% description %] [% title %][% accounttype %][% notify_id %][% notify_level %][% amount | format('%.2f') %][% amountoutstanding | format('%.2f') %]
Writeoff This Charge?
- - Cancel -
DescriptionAccount TypeNotify idLevelAmountAmount Outstanding
Total amount to be written off:[% amountoutstanding | format('%.2f') %]
[% description %] [% title %][% accounttype %][% notify_id %][% notify_level %][% amount | format('%.2f') %][% amountoutstanding | format('%.2f') %]
+
+
[% ELSE %] @@ -194,27 +188,22 @@ function moneyFormat(textObj) { - - - - - - - - - - - - - - -
Total Amount Outstanding : [% total | format('%.2f') %]
Collect From Patron: +
+ [% IF ( selected_accts ) %]Pay an amount toward selected fines[% ELSE %]Pay an amount toward all fines[% END %] +
    +
  1. + Total amount outstanding: + [% total | format('%.2f') %] +
  2. +
  3. + -
- - Cancel -
+ + + + [% END %]
-- 1.7.3