Bugzilla – Attachment 74596 Details for
Bug 19974
Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19974: (QA follow-up) Do not use bar separator in atomic update
Bug-19974-QA-follow-up-Do-not-use-bar-separator-in.patch (text/plain), 1.28 KB, created by
Marcel de Rooy
on 2018-04-20 06:29:02 UTC
(
hide
)
Description:
Bug 19974: (QA follow-up) Do not use bar separator in atomic update
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-04-20 06:29:02 UTC
Size:
1.28 KB
patch
obsolete
>From c475aa918573728c33ffccfa7ce867873923400e Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 20 Apr 2018 08:21:33 +0200 >Subject: [PATCH] Bug 19974: (QA follow-up) Do not use bar separator in atomic > update >Content-Type: text/plain; charset=utf-8 > >The multiple select saves the selected values with a comma. >Furthermore, preferences.pl also splits on a comma. In other words, the >upgrade will not work with the bar character. All options will be >deselected. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/atomicupdate/bug_19974.perl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_19974.perl b/installer/data/mysql/atomicupdate/bug_19974.perl >index 78ff577..602fa89 100644 >--- a/installer/data/mysql/atomicupdate/bug_19974.perl >+++ b/installer/data/mysql/atomicupdate/bug_19974.perl >@@ -8,7 +8,7 @@ if( CheckVersion( $DBversion ) ) { > UPDATE systempreferences > SET type="multiple", > options="batchmod|moredetail|cronjob|additem", >- value="batchmod|moredetail|cronjob|additem" >+ value="batchmod,moredetail,cronjob,additem" > WHERE variable="MarkLostItemsAsReturned" > }); > } else { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19974
:
70525
|
73162
|
73163
|
73531
|
74106
|
74167
|
74238
|
74542
|
74564
|
74565
|
74566
|
74591
|
74594
|
74595
| 74596