Bugzilla – Attachment 74623 Details for
Bug 19873
Make it possible to search on value 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19873: Add unit tests
Bug-19873-Add-unit-tests.patch (text/plain), 1.60 KB, created by
Julian Maurice
on 2018-04-20 12:36:06 UTC
(
hide
)
Description:
Bug 19873: Add unit tests
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-04-20 12:36:06 UTC
Size:
1.60 KB
patch
obsolete
>From 22bcb912eef4e8f0584a72c22dd333a00c262b57 Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Thu, 1 Mar 2018 13:23:44 +0000 >Subject: [PATCH] Bug 19873: Add unit tests > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > t/db_dependent/Search.t | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t >index a1ec226694..15a885da9f 100644 >--- a/t/db_dependent/Search.t >+++ b/t/db_dependent/Search.t >@@ -619,6 +619,11 @@ if ( $indexing_mode eq 'dom' ) { > is( $query, "an:42 and ( ( allrecords,AlwaysMatches:'' not onloan,AlwaysMatches:'') and (lost,st-numeric=0) )", 'buildQuery should add the available part to the query if requested with ccl' ); > is( $query_desc, 'an:42', 'buildQuery should remove the available part from the query' ); > >+ ( $error, $query, $simple_query, $query_cgi, >+ $query_desc, $limit, $limit_cgi, $limit_desc, >+ $query_type ) = buildQuery([], [ 0 ], [ 'su,phr' ], [], [], 0, 'en'); >+ is($query, 'su,phr=0 ', 'buildQuery should keep 0 value'); >+ > # Let's see what happens when we pass bad data into these routines. > # We have to catch warnings since we're not very good about returning errors. > >@@ -970,12 +975,12 @@ sub run_unimarc_search_tests { > } > > subtest 'MARC21 + GRS-1' => sub { >- plan tests => 109; >+ plan tests => 110; > run_marc21_search_tests('grs1'); > }; > > subtest 'MARC21 + DOM' => sub { >- plan tests => 109; >+ plan tests => 110; > run_marc21_search_tests('dom'); > }; > >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19873
:
70122
|
72307
|
72839
|
72840
|
74622
| 74623 |
74624