Bugzilla – Attachment 74674 Details for
Bug 2696
Fine payments should show what was paid for
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 2696: (QA follow-up) Several fixes to template variables
Bug-2696-QA-follow-up-Several-fixes-to-template-va.patch (text/plain), 4.09 KB, created by
Katrin Fischer
on 2018-04-21 09:21:20 UTC
(
hide
)
Description:
Bug 2696: (QA follow-up) Several fixes to template variables
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-04-21 09:21:20 UTC
Size:
4.09 KB
patch
obsolete
>From f39b75f69a107e8570a1a77e647acc3d74728ccd Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 21 Apr 2018 00:40:15 +0000 >Subject: [PATCH] Bug 2696: (QA follow-up) Several fixes to template variables > >- Fix link to patron account in breadcrumbs >- Fix includes for accounttype.inc to display type correctly > - in Details for fee > - in Payments list >- Fix use CGI qw ( -utf8 ); >- Remove <br> from within a string for better translation >--- > .../intranet-tmpl/prog/en/modules/members/accountline-details.tt | 8 ++++---- > members/accountline-details.pl | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >index 5e5a504..aaaa78c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >@@ -10,7 +10,7 @@ > [% INCLUDE 'header.inc' %] > [% INCLUDE 'patron-search.inc' %] > >-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a> › <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% borrowernumber %]">Account for [% INCLUDE 'patron-title.inc' %]</a> › Details for account line [% accountline.id %]</div> >+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a> › <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% patron.borrowernumber %]">Account for [% INCLUDE 'patron-title.inc' %]</a> › Details for account line [% accountline.id %]</div> > > <div id="doc3" class="yui-t2"> > <div id="bd"> >@@ -40,7 +40,7 @@ > <span title="[% accountline.date %]">[% accountline.date |$KohaDates %]</span> > </td> > <td> >- [% INCLUDE 'accounttype.inc' accountline => accountline %] >+ [%- INCLUDE 'accounttype.inc' account => accountline -%] > [%- IF accountline.payment_type -%] > , [% AuthorisedValues.GetByCode('PAYMENT_TYPE', accountline.payment_type) %] > [%- END =%] >@@ -85,7 +85,7 @@ > <th>Amount outstanding</th> > <th>Type</th> > <th>Note</th> >- <th>Transacting<br/>librarian id</th> >+ <th>Transacting librarian</th> > <th>Date/Time of change</th> > <th>Amount of change</th> > <th>Type of change</th> >@@ -107,7 +107,7 @@ > <td>[% offset_accountline.timestamp | $KohaDates with_hours => 1 %]</td> > <td>[% offset_accountline.amount | $Price %]</td> > <td>[% offset_accountline.amountoutstanding | $Price %]</td> >- <td>[% INCLUDE 'accounttype.inc' accountline => offset_accountline %]</td> >+ <td>[% INCLUDE 'accounttype.inc' account => offset_accountline %]</td> > <td>[% offset_accountline.note %]</td> > <td>[% IF offset_accountline.manager_id %]<a href="moremember.pl?borrowernumber=[% offset_accountline.manager_id %]">[% offset_accountline.manager_id %]</a>[% END %]</td> > <td>[% ao.created_on | $KohaDates with_hours => 1 %]</td> >diff --git a/members/accountline-details.pl b/members/accountline-details.pl >index cd22d80..856516c 100644 >--- a/members/accountline-details.pl >+++ b/members/accountline-details.pl >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use CGI; >+use CGI qw ( -utf8 ); > use C4::Auth; > use C4::Output; > use C4::Context; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2696
:
800
|
3069
|
9583
|
64287
|
64293
|
64342
|
64345
|
64346
|
64350
|
67479
|
70031
|
72024
|
72088
|
72263
|
74672
|
74673
| 74674 |
74765
|
74817