Bugzilla – Attachment 74703 Details for
Bug 19287
Add ability to mark an item 'Lost' from 'Holds to pull' list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19287: Do not display buttons for biblio level holds
Bug-19287-Do-not-display-buttons-for-biblio-level-.patch (text/plain), 3.65 KB, created by
Katrin Fischer
on 2018-04-22 18:45:05 UTC
(
hide
)
Description:
Bug 19287: Do not display buttons for biblio level holds
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-04-22 18:45:05 UTC
Size:
3.65 KB
patch
obsolete
>From 6c3b2ecc5062e47781cf6e225f3003728b036117 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 9 Apr 2018 15:08:42 -0300 >Subject: [PATCH] Bug 19287: Do not display buttons for biblio level holds > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > circ/pendingreserves.pl | 2 +- > .../prog/en/modules/circ/pendingreserves.tt | 26 +++++++++++++--------- > 2 files changed, 16 insertions(+), 12 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 6f47a31..5e6418b 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -177,7 +177,7 @@ my $strsth = > ORDER BY items.itemnumber SEPARATOR '|') l_holdingbranch, > reserves.biblionumber, > reserves.branchcode as l_branch, >- items.itemnumber, >+ reserves.itemnumber, > items.holdingbranch, > items.homebranch, > GROUP_CONCAT(DISTINCT items.itype >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index f56bd81..ccac35f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -36,7 +36,7 @@ > [% CASE 'hold_cancelled' %] > <span>The hold has been correctly cancelled.</span> > [% CASE 'hold_placed_at_biblio_level' %] >- <span>The hold has been placed at biblio level. It is not possible to mark it as lost.</span> >+ <span>The hold has been placed on biblio level. It is not possible to determine the item to mark as lost.</span> > [% CASE %] > [% m.code %] > [% END %] >@@ -120,16 +120,20 @@ > </form> > > [% IF Koha.Preference('CanMarkHoldsToPullAsLost') != 'do_not_allow' %] >- <form name="cancelReserve" action="/cgi-bin/koha/circ/pendingreserves.pl" method="post"> >- <input type="hidden" name="reserve_id" value="[% reserveloo.reserve_id %]" /> >- [% IF Koha.Preference('CanMarkHoldsToPullAsLost') == 'allow' %] >- <input type="hidden" name="op" value="mark_as_lost" /> >- <input type="submit" value="Mark item as lost" /> >- [% ELSIF Koha.Preference('CanMarkHoldsToPullAsLost') == 'allow_and_notify' %] >- <input type="hidden" name="op" value="mark_as_lost_and_notify" /> >- <input type="submit" value="Mark item as lost and notify the patron" /> >- [% END %] >- </form> >+ [% IF reserveloo.itemnumber %] >+ <form name="cancelReserve" action="/cgi-bin/koha/circ/pendingreserves.pl" method="post"> >+ <input type="hidden" name="reserve_id" value="[% reserveloo.reserve_id %]" /> >+ [% IF Koha.Preference('CanMarkHoldsToPullAsLost') == 'allow' %] >+ <input type="hidden" name="op" value="mark_as_lost" /> >+ <input type="submit" value="Mark item as lost" /> >+ [% ELSIF Koha.Preference('CanMarkHoldsToPullAsLost') == 'allow_and_notify' %] >+ <input type="hidden" name="op" value="mark_as_lost_and_notify" /> >+ <input type="submit" value="Mark item as lost and notify the patron" /> >+ [% END %] >+ </form> >+ [% ELSE %] >+ <span>Biblio level hold.</span> >+ [% END %] > [% END %] > </tr> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19287
:
68226
|
68227
|
68228
|
68229
|
68230
|
68251
|
68252
|
68253
|
68254
|
68255
|
68284
|
69746
|
70705
|
70764
|
70918
|
70919
|
73881
|
73882
|
73883
|
73884
|
73885
|
73886
|
73887
|
73888
|
73889
|
74696
|
74697
|
74698
|
74699
|
74700
|
74701
|
74702
| 74703 |
74704
|
74705
|
74749
|
75535