From 5121a7907d275c3ddad9d19ed83d30c6c4758f2d Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Tue, 17 Apr 2018 23:59:58 +0000 Subject: [PATCH] Bug 20592: Checks for itemnumber sooner Two lines of code and move them earlier. Add a check to make sure there are changes. --- C4/Items.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/C4/Items.pm b/C4/Items.pm index e7279ff8a1..d2c66f8e6f 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -557,6 +557,9 @@ sub ModItem { my $log_action = $additional_params->{log_action} // 1; my $unlinked_item_subfields = $additional_params->{unlinked_item_subfields}; + return unless %$item; + $item->{'itemnumber'} = $itemnumber or return; + # if $biblionumber is undefined, get it from the current item unless (defined $biblionumber) { $biblionumber = _get_single_item_column('biblionumber', $itemnumber); @@ -566,8 +569,6 @@ sub ModItem { $item->{'more_subfields_xml'} = _get_unlinked_subfields_xml($unlinked_item_subfields); }; - $item->{'itemnumber'} = $itemnumber or return; - my @fields = qw( itemlost withdrawn damaged ); # Only call GetItem if we need to set an "on" date field -- 2.11.0