From 60e8095bebeacdaac5e7ee8fb00feba9f782c98b Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 25 Apr 2018 12:38:25 +0000
Subject: [PATCH] Bug 20329: Text input fields are wider than the fieldset
 class they are inside of

This alternate patch defines a width of 100% for text inputs and selects
inside sidebar fieldsets. The scope of this style is limited to the
sidebar by unsetting the width for fieldsets within "#yui-main," the
main body of the page.

This patch also removes inline styles from two templates which are now
unnecessary.

To test, apply the patch and clear your cache if necessary.

View various pages which have a sidebar search form: acqui/invoices.pl,
members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that
form fields in the sidebar look correct.

Confirm that other forms styled with the "brief" class aren't
unintentionally affected by this patch. For example:
circ/request-article.pl, members/member-password.pl,
reports/reports-home.pl, reserve/request.pl

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css        | 16 +++++++++-------
 .../intranet-tmpl/prog/en/modules/acqui/basketgroup.tt   |  4 ++--
 .../intranet-tmpl/prog/en/modules/admin/aqbudgets.tt     |  2 +-
 3 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
index ec05505ff3..c68bff67f9 100644
--- a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
@@ -125,11 +125,6 @@ input[type="checkbox"], input[type="radio"] {
     margin: 0;
 }
 
-/*Set width of filter input text boxes*/
-input[name="borname"], input[id="searchmember_filter"], input[id="bookseller"], input[id="publisher"], input[id="callnumber"], input[id="title"], input[id="issn"], input[id="invoicenumber"], input[id="isbneanissn"], input[id="author"], input[id="publicationyear"], input[id="summaryfilter"], input[id="basketfilter"], input[id="basketgroupnamefilter"], input[id="orderfilter"] {
-    width:140px;
-}
-
 label, .label {
     display: inline;
     font-weight: normal;
@@ -633,9 +628,11 @@ div.yui-b fieldset.brief ol {
 	padding : 0;
 }
 
-div.yui-b fieldset.brief select {
-	width: 12em;
+div.yui-b fieldset.brief select,
+div.yui-b fieldset.brief input[type=text] {
+    width: 100%;
 }
+
 div.yui-b fieldset.brief li.radio {
 	padding : .7em 0;
 }
@@ -660,6 +657,11 @@ div.yui-b fieldset.brief fieldset legend {
 	font-size : 85%;
 }
 
+#yui-main div.yui-b fieldset.brief select,
+#yui-main div.yui-b fieldset.brief input[type=text] {
+    width: auto;
+}
+
 #tools_holidays fieldset.brief li.radio input,
 #tools_holidays fieldset.brief li.checkbox input{
     margin-left: 0;
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
index 4c3e833455..dab44d89b6 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
@@ -202,7 +202,7 @@ function submitForm(form) {
                                         <li>
                                             [% UNLESS (closedbg) %]
                                                 <label for="billingplace">Billing place:</label>
-                                                <select name="billingplace" id="billingplace" style="width:13em;">
+                                                <select name="billingplace" id="billingplace">
                                                     <option value="">--</option>
                                                     [% PROCESS options_for_libraries libraries => Branches.all( selected => billingplace ) %]
                                                 </select>
@@ -214,7 +214,7 @@ function submitForm(form) {
                                         [% UNLESS (closedbg) %]
                                             <li>
                                                 <label for="deliveryplace">Delivery place:</label>
-                                                <select name="deliveryplace" id="deliveryplace" style="width:13em;">
+                                                <select name="deliveryplace" id="deliveryplace">
                                                     <option value="">--</option>
                                                     [% PROCESS options_for_libraries libraries => Branches.all( selected => deliveryplace ) %]
                                                 <select>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
index 1e797823b5..25d3d8ebd3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
@@ -401,7 +401,7 @@
         <ol>
         <li>
             <label for="filter_budgetbranch2">Library: </label>
-            <select name="filter_budgetbranch" id="filter_budgetbranch2" style="width:10em;">
+            <select name="filter_budgetbranch" id="filter_budgetbranch2">
                 <option value=""></option>
                 [% PROCESS options_for_libraries libraries => Branches.all( selected => budget_branchcode, unfiltered => 1 ) %]
             </select>
-- 
2.11.0