From 58969824814b95b63979cb73ddb4c47822fbb07b Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Mon, 7 May 2018 15:51:33 +0000 Subject: [PATCH] Bug 20505: Friendlier death message Actually telling the user where to look to solve the problem is more helpful than just expecting them to know why the selenium driver didn't load. prove t/db_dependent/selenium/ --- t/db_dependent/selenium/administration_tasks.t | 4 +++- t/db_dependent/selenium/basic_workflow.t | 9 +++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/selenium/administration_tasks.t b/t/db_dependent/selenium/administration_tasks.t index 5f65b59..69fc9c1 100644 --- a/t/db_dependent/selenium/administration_tasks.t +++ b/t/db_dependent/selenium/administration_tasks.t @@ -47,7 +47,9 @@ SKIP: { try { $s = t::lib::Selenium->new; } catch { - skip "Unable to create selenium driver link. Please review https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha", 1; + diag "\nUnable to create selenium driver link. Please review https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha"; + fail; + exit 0; }; my $driver = $s->driver; diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t index 325710a..f17da6f 100644 --- a/t/db_dependent/selenium/basic_workflow.t +++ b/t/db_dependent/selenium/basic_workflow.t @@ -38,7 +38,7 @@ use Time::HiRes qw(gettimeofday); use C4::Context; use C4::Biblio qw( AddBiblio ); # We shouldn't use it -use Test::More tests => 20; +use Test::More; use MARC::Record; use MARC::Field; use Try::Tiny; @@ -90,7 +90,10 @@ SKIP: { try { $s = t::lib::Selenium->new; } catch { - skip "Unable to create selenium driver link. Please review https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha", 20; + diag "\nUnable to create selenium driver link. Please review https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha"; + fail; + done_testing(); + exit 0; }; open my $fh, '>>', '/tmp/output.txt'; @@ -204,6 +207,8 @@ SKIP: { $driver->quit(); }; +done_testing(); + END { cleanup() if $cleanup_needed; }; -- 2.1.4