Bugzilla – Attachment 75137 Details for
Bug 20721
Circulation.t keeps failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20721: (bug 19403 follow-up) Prevent Circulation.t to fail randomly
Bug-20721-bug-19403-follow-up-Prevent-Circulationt.patch (text/plain), 3.95 KB, created by
Jonathan Druart
on 2018-05-07 16:17:08 UTC
(
hide
)
Description:
Bug 20721: (bug 19403 follow-up) Prevent Circulation.t to fail randomly
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-05-07 16:17:08 UTC
Size:
3.95 KB
patch
obsolete
>From 8bb531b5308635d53345cd04617b47acb076970e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 7 May 2018 13:15:34 -0300 >Subject: [PATCH] Bug 20721: (bug 19403 follow-up) Prevent Circulation.t to > fail randomly > >If items.restricted == 1, CanBookBeIssued will not returned what we are >testing. > >The easiest and global fix is to define a default value at TestBuilder >package level > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Circulation.t | 22 ---------------------- > t/lib/TestBuilder.pm | 4 ++++ > 2 files changed, 4 insertions(+), 22 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index d8de2e220b..e93b019c5b 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -1216,10 +1216,6 @@ subtest 'CanBookBeIssued & AllowReturnToBranch' => sub { > value => { > homebranch => $homebranch->{branchcode}, > holdingbranch => $holdingbranch->{branchcode}, >- notforloan => 0, >- itemlost => 0, >- withdrawn => 0, >- restricted => 0, > biblionumber => $biblioitem->{biblionumber} > } > } >@@ -1381,10 +1377,6 @@ subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub { > value => { > homebranch => $library->{branchcode}, > holdingbranch => $library->{branchcode}, >- notforloan => 0, >- itemlost => 0, >- withdrawn => 0, >- restricted => 0, > biblionumber => $biblioitem_1->{biblionumber} > } > } >@@ -1395,10 +1387,6 @@ subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub { > value => { > homebranch => $library->{branchcode}, > holdingbranch => $library->{branchcode}, >- notforloan => 0, >- itemlost => 0, >- withdrawn => 0, >- restricted => 0, > biblionumber => $biblioitem_2->{biblionumber} > } > } >@@ -1462,10 +1450,6 @@ subtest 'CanBookBeIssued + Statistic patrons "X"' => sub { > value => { > homebranch => $library->branchcode, > holdingbranch => $library->branchcode, >- notforloan => 0, >- itemlost => 0, >- withdrawn => 0, >- restricted => 0, > biblionumber => $biblioitem_1->{biblionumber} > } > } >@@ -1592,9 +1576,6 @@ subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub { > value => { > homebranch => $library->{branchcode}, > holdingbranch => $library->{branchcode}, >- notforloan => 0, >- itemlost => 0, >- withdrawn => 0, > biblionumber => $biblionumber, > } > } >@@ -1604,9 +1585,6 @@ subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub { > value => { > homebranch => $library->{branchcode}, > holdingbranch => $library->{branchcode}, >- notforloan => 0, >- itemlost => 0, >- withdrawn => 0, > biblionumber => $biblionumber, > } > } >diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm >index 1aa6de9762..c44e8895ea 100644 >--- a/t/lib/TestBuilder.pm >+++ b/t/lib/TestBuilder.pm >@@ -471,6 +471,10 @@ sub _gen_default_values { > borrowernotes => '', > }, > Item => { >+ notforloan => 0, >+ itemlost => 0, >+ withdrawn => 0, >+ restricted => 0, > more_subfields_xml => undef, > }, > Category => { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20721
: 75137