From c74993ff3baa55a141f65dc42a4181ff6edee8e7 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 7 May 2018 20:49:16 -0300 Subject: [PATCH] Bug 20726: Remove GetLastOrder* subroutines They are not used elsewhere. --- t/db_dependent/Acquisition/OrderFromSubscription.t | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/t/db_dependent/Acquisition/OrderFromSubscription.t b/t/db_dependent/Acquisition/OrderFromSubscription.t index cc691d0585..3d2859b99f 100644 --- a/t/db_dependent/Acquisition/OrderFromSubscription.t +++ b/t/db_dependent/Acquisition/OrderFromSubscription.t @@ -1,6 +1,6 @@ use Modern::Perl; -use Test::More tests => 12; +use Test::More tests => 7; use t::lib::TestBuilder; @@ -80,10 +80,6 @@ my $ordernumber = $order->ordernumber; my $is_currently_on_order = subscriptionCurrentlyOnOrder( $subscription->{subscriptionid} ); is ( $is_currently_on_order, 1, "The subscription is currently on order"); -$order = GetLastOrderNotReceivedFromSubscriptionid( $subscription->{subscriptionid} ); -is ( $order->{subscriptionid}, $subscription->{subscriptionid}, "test subscriptionid for the last order not received"); -ok( $order->{ecost} == $cost, "test cost for the last order not received"); - $dbh->do(q{DELETE FROM aqinvoices}); my $invoiceid = AddInvoice(invoicenumber => 'invoice1', booksellerid => $bookseller->id, unknown => "unknown"); @@ -93,20 +89,13 @@ $invoice->{datereceived} = '2013-01-02'; my ( $datereceived, $new_ordernumber ) = ModReceiveOrder( { biblionumber => $biblionumber, - order => $order, + order => $order->unblessed, quantityreceived => 1, budget_id => $budget_id, invoice => $invoice, } ); -$order = GetLastOrderReceivedFromSubscriptionid( $subscription->{subscriptionid} ); -is ( $order->{subscriptionid}, $subscription->{subscriptionid}, "test subscriptionid for the last order received"); -ok( $order->{ecost} == $cost, "test cost for the last order received"); - -$order = GetLastOrderNotReceivedFromSubscriptionid( $subscription->{subscriptionid} ); -is ( $order, undef, "test no not received order for a received order"); - my @invoices = GetInvoices(); my @invoices_linked_to_subscriptions = grep { $_->{is_linked_to_subscriptions} } @invoices; is(scalar(@invoices_linked_to_subscriptions), 1, 'GetInvoices() can identify invoices that are linked to a subscription'); -- 2.11.0