Bugzilla – Attachment 75197 Details for
Bug 18889
Add barcode to 'Pay Fines' tab in patrons payment page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18889: Simpler counter-patch
Bug-18889-Simpler-counter-patch.patch (text/plain), 1.90 KB, created by
Alex Buckley
on 2018-05-09 02:38:53 UTC
(
hide
)
Description:
Bug 18889: Simpler counter-patch
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2018-05-09 02:38:53 UTC
Size:
1.90 KB
patch
obsolete
>From afb88802f18894b664ebe7d274d19a69f157cbe9 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 2 Apr 2018 01:28:59 +0000 >Subject: [PATCH] Bug 18889: Simpler counter-patch > >There is no need to add barcode into the accountlines >table, as a relationship via itemnumber can easily look it up. > >Followed test plan, works as described. Passes QA test tool > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 2 ++ > members/pay.pl | 1 + > 2 files changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >index 80abac0..03c2bb1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >@@ -42,6 +42,7 @@ > <th> </th> > <th>Fines & charges</th> > <th>Description</th> >+ <th>Barcode</th> > <th>Payment note</th> > <th>Account type</th> > <th>Amount</th> >@@ -102,6 +103,7 @@ > [%- IF line.description %], [% line.description %][% END %] > [% IF line.title %]([% line.title %])[% END %] > </td> >+ <td>[% line.barcode %]</td> > <td><input type="text" name="payment_note_[% line.accountlines_id %]" /></td> > <td>[% line.accounttype %]</td> > <td class="debit" style="text-align: right;">[% line.amount | $Price %]</td> >diff --git a/members/pay.pl b/members/pay.pl >index 05b73e5..039d5cc 100755 >--- a/members/pay.pl >+++ b/members/pay.pl >@@ -135,6 +135,7 @@ sub add_accounts_to_template { > my $biblio = $item->biblio; > $account_line->{biblionumber} = $biblio->biblionumber; > $account_line->{title} = $biblio->title; >+ $account_line->{barcode} = $item ? $item->barcode : q{}; > } > push @accounts, $account_line; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18889
:
64772
|
69352
|
73362
|
73365
|
73366
|
73519
|
75197
|
75198