From 5f5fdc67738b5285fb4b9eea4e132c9fe4232d1f Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi <tomascohen@theke.io> Date: Thu, 29 Mar 2018 10:45:30 -0300 Subject: [PATCH] Bug 20428: Make about.pl inform about missing upload_tmp_path entry Content-Type: text/plain; charset=utf-8 This patch makes about.pl warn about a missing upload_tmp_path entry in koha-conf.xml. It also mentions the effectively used tmp dir. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- about.pl | 8 ++++++++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/about.pl b/about.pl index b3cad66..6fdb578 100755 --- a/about.pl +++ b/about.pl @@ -46,6 +46,7 @@ use Koha::Caches; use Koha::Config::SysPrefs; use Koha::Illrequest::Config; use Koha::SearchEngine::Elasticsearch; +use Koha::UploadedFiles; use C4::Members::Statistics; @@ -260,6 +261,13 @@ if ( ! defined C4::Context->config('upload_path') ) { } } +if ( ! defined C4::Context->config('upload_tmp_path') ) { + push @xml_config_warnings, { + error => 'uploadtmppath_entry_missing', + effective_upload_tmp_dir => Koha::UploadedFile->temporary_directory + } +} + # Test QueryParser configuration sanity if ( C4::Context->preference( 'UseQueryParser' ) ) { # Get the QueryParser configuration file name diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt index abcd8c3..0e462b6 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt @@ -414,6 +414,14 @@ Also note that you need to properly set the OPACBaseURL preference for the file upload plugin to work. </td> </tr> + [% ELSIF config_entry.error == 'uploadtmppath_entry_missing' %] + <tr> + <th scope="row"><b>Warning</b></th> + <td>You are missing the <upload_tmp_path> entry in your koha-conf.xml file. Please + add it, pointing to the configured temporary file upload directory for your Koha instance. + The effective temporary file upload directory is '[% config_entry.effective_upload_tmp_dir %]' + </td> + </tr> [% END %] [% END %] </table> -- 2.1.4