From cbeb195097f763e064ea216642423e9daba62bf3 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 28 May 2018 15:11:09 -0300 Subject: [PATCH] Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl circ/returns.pl does not send a $patron Koha::Patron object to the template in case print_slip is set Test plan: Confirm a hold and print the slip --- circ/returns.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/circ/returns.pl b/circ/returns.pl index b26be73961..1e09336ac1 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -78,7 +78,7 @@ if ($session->param('branch') eq 'NO_LIBRARY_SET'){ if ( $query->param('print_slip') ) { $template->param( print_slip => 1, - borrowernumber => scalar $query->param('borrowernumber'), + borrowernumber => scalar $query->param('borrowernumber'), # FIXME We should send a Koha::Patron and raise an error if not exist. biblionumber => scalar $query->param('biblionumber'), ); } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index cf27d1c3ea..119116fa07 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -709,7 +709,7 @@ $(".modal").on('hidden.bs.modal', function (e) { $("#barcode").focus(); }); [% IF print_slip %] - Dopop('hold-transfer-slip.pl?borrowernumber=[% patron.borrowernumber %]&biblionumber=[% biblionumber %]'); + Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&biblionumber=[% biblionumber %]'); [% END %] var columns_settings = [% ColumnsSettings.GetColumns( 'circ', 'returns', 'checkedintable', 'json' ) %] -- 2.11.0