From f00957976120f76af9ff23840999c27bd484ea23 Mon Sep 17 00:00:00 2001
From: Josef Moravec <josef.moravec@gmail.com>
Date: Tue, 29 May 2018 09:15:09 +0000
Subject: [PATCH] Bug 20806: Add item type description holds history page

Test plan:

0) Do not apply the patch
1) Set AllowHoldItemTypeSelection to Allow
2) Place some hold for a patron, some with specific item type and some
without item typ
3) On holds history page you should see blank or item type code in item
type column
4) Apply the patch
5) Now you should see description in item type column
---
 .../intranet-tmpl/prog/en/modules/members/holdshistory.tt     | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
index f2e8ebb..75399d0 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
@@ -4,6 +4,7 @@
 [% USE AuthorisedValues %]
 [% USE Branches %]
 [% USE ColumnsSettings %]
+[% USE ItemTypes %]
 [% SET footerjs = 1 %]
 [% INCLUDE 'doc-head-open.inc' %]
 <title>Holds history for [% INCLUDE 'patron-title.inc' no_html = 1 %]</title>
@@ -43,7 +44,7 @@
         <th class="title-string">Expiration date</th>
         <th class="title-string">Waiting date</th>
         <th class="title-string">Cancellation date</th>
-        <th>Item type</th>
+        <th>Requested item type</th>
         <th>Status</th>
       </thead>
       <tbody>
@@ -74,7 +75,13 @@
                   <span title="0000-00-00"></span>
               [% END %]
           </td>
-          <td>[% hold.itemtype %]</td>
+          <td>
+              [% IF hold.itemtype %]
+                  [% ItemTypes.GetDescription( hold.itemtype ) %]
+              [% ELSE %]
+                  Any item type
+              [% END %]
+          </td>
           <td>
           [% IF hold.found == 'F' %]
               Fulfilled
-- 
2.1.4