From eb9142f66ab2439818176fd0570bf7bb02fb5641 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 18 May 2018 08:00:03 -0400 Subject: [PATCH] Bug 17561: (QA follow-up) Update existing unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart --- t/db_dependent/Letters/TemplateToolkit.t | 8 ++++---- t/db_dependent/Reserves.t | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/t/db_dependent/Letters/TemplateToolkit.t b/t/db_dependent/Letters/TemplateToolkit.t index 3501d49bae..a3ee634b51 100644 --- a/t/db_dependent/Letters/TemplateToolkit.t +++ b/t/db_dependent/Letters/TemplateToolkit.t @@ -555,8 +555,8 @@ You have [% count %] items due EOF reset_template( { template => $template, code => $code, module => 'circulation' } ); - my $letter_for_item1 = C4::Reserves::ReserveSlip( $library->{branchcode}, $patron->{borrowernumber}, $biblio1->{biblionumber} ); - my $letter_for_item2 = C4::Reserves::ReserveSlip( $library->{branchcode}, $patron->{borrowernumber}, $biblio2->{biblionumber} ); + my $letter_for_item1 = C4::Reserves::ReserveSlip( { branchcode => $library->{branchcode}, borrowernumber => $patron->{borrowernumber}, biblionumber => $biblio1->{biblionumber} } ); + my $letter_for_item2 = C4::Reserves::ReserveSlip( { branchcode => $library->{branchcode}, borrowernumber => $patron->{borrowernumber}, biblionumber => $biblio2->{biblionumber} } ); my $tt_template = <Date: [% today | \$KohaDates with_hours => 1 %] @@ -589,8 +589,8 @@ EOF EOF reset_template( { template => $tt_template, code => $code, module => 'circulation' } ); - my $tt_letter_for_item1 = C4::Reserves::ReserveSlip( $library->{branchcode}, $patron->{borrowernumber}, $biblio1->{biblionumber} ); - my $tt_letter_for_item2 = C4::Reserves::ReserveSlip( $library->{branchcode}, $patron->{borrowernumber}, $biblio2->{biblionumber} ); + my $tt_letter_for_item1 = C4::Reserves::ReserveSlip( { branchcode => $library->{branchcode}, borrowernumber => $patron->{borrowernumber}, biblionumber => $biblio1->{biblionumber} } ); + my $tt_letter_for_item2 = C4::Reserves::ReserveSlip( { branchcode => $library->{branchcode}, borrowernumber => $patron->{borrowernumber}, biblionumber => $biblio2->{biblionumber} } ); is( $tt_letter_for_item1->{content}, $letter_for_item1->{content}, ); is( $tt_letter_for_item2->{content}, $letter_for_item2->{content}, ); diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index e0bba34d48..4fae478dd3 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -390,7 +390,7 @@ is( 'item that is captured to fill a hold cannot be deleted', ); -my $letter = ReserveSlip($branch_1, $requesters{$branch_1}, $bibnum); +my $letter = ReserveSlip( { branchcode => $branch_1, borrowernumber => $requesters{$branch_1}, biblionumber => $bibnum } ); ok(defined($letter), 'can successfully generate hold slip (bug 10949)'); # Tests for bug 9788: Does Koha::Item->current_holds return a future wait? -- 2.11.0