From b19bf33ef691ea30997e44ccdd71edd78dcd9a9f Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 10 Feb 2012 10:43:29 -0500 Subject: [PATCH] Bug 6898 - circulation librarians can't run overdues without reports permissions This commit adds a new user permission execute_overdues_report for the reports module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. --- circ/overdue.pl | 2 +- .../data/mysql/en/mandatory/userpermissions.sql | 3 ++- installer/data/mysql/updatedatabase.pl | 8 ++++++++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/circ/overdue.pl b/circ/overdue.pl index a7207b7..5acd41f 100755 --- a/circ/overdue.pl +++ b/circ/overdue.pl @@ -51,7 +51,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( query => $input, type => "intranet", authnotrequired => 0, - flagsrequired => { reports => 1, circulate => "circulate_remaining_permissions" }, + flagsrequired => { reports => "execute_overdues_report", circulate => "circulate_remaining_permissions" }, debug => 1, } ); diff --git a/installer/data/mysql/en/mandatory/userpermissions.sql b/installer/data/mysql/en/mandatory/userpermissions.sql index 873089a..b6724ac 100644 --- a/installer/data/mysql/en/mandatory/userpermissions.sql +++ b/installer/data/mysql/en/mandatory/userpermissions.sql @@ -46,5 +46,6 @@ INSERT INTO permissions (module_bit, code, description) VALUES (15, 'renew_subscription', 'Renew a subscription'), (15, 'routing', 'Routing'), (16, 'execute_reports', 'Execute SQL reports'), - (16, 'create_reports', 'Create SQL Reports') + (16, 'create_reports', 'Create SQL Reports'), + (16, 'execute_overdues_report', 'Execute overdue items report') ; diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 099dfb9..42671f8 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -4663,6 +4663,14 @@ ENDOFRENEWAL print "Upgrade to $DBversion done (Added a system preference to allow renewal of Patron account either from todays date or from existing expiry date in the patrons account.)\n"; SetVersion($DBversion); } + +$DBversion = "3.07.00.XXX"; +if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { + $dbh->do("INSERT INTO permissions ( module_bit, code, description ) VALUES ( '16', 'execute_overdues_report', 'Execute overdue items report' )"); + print "Upgrade to $DBversion done ( Add Reports permission execute_overdues_report )\n"; + SetVersion($DBversion); +} + =head1 FUNCTIONS =head2 DropAllForeignKeys($table) -- 1.7.2.5