Bugzilla – Attachment 75750 Details for
Bug 20866
ArticleRequests.t fails on existing requests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20866: Fix ArticleRequests.t when table contains records
Bug-20866-Fix-ArticleRequestst-when-table-contains.patch (text/plain), 1.21 KB, created by
Marcel de Rooy
on 2018-06-04 08:30:17 UTC
(
hide
)
Description:
Bug 20866: Fix ArticleRequests.t when table contains records
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-06-04 08:30:17 UTC
Size:
1.21 KB
patch
obsolete
>From 2119e88bbdf1073a69543a5d8881e9dfa876a7a7 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 4 Jun 2018 10:26:01 +0200 >Subject: [PATCH] Bug 20866: Fix ArticleRequests.t when table contains records >Content-Type: text/plain; charset=utf-8 > >Subtest search_limited fails. Assumptions in that code may not be true. >Simple fix for now: clear the table at the start. > >Test plan: >[1] Create an article request. >[2] Run t/db_dependent/ArticleRequests.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/ArticleRequests.t | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/ArticleRequests.t b/t/db_dependent/ArticleRequests.t >index 7c99657..4cd5109 100755 >--- a/t/db_dependent/ArticleRequests.t >+++ b/t/db_dependent/ArticleRequests.t >@@ -78,7 +78,9 @@ ok( $patron->id, 'Koha::Patron created' ); > my $patron_2 = $builder->build({ source => 'Borrower', value => { flags => 0 } }); > $patron_2 = Koha::Patrons->find( $patron_2->{borrowernumber} ); > >-my $nb_article_requests = Koha::ArticleRequests->count; >+# Clear current article requests >+Koha::ArticleRequests->delete; >+my $nb_article_requests = 0; > > # store > Koha::Notice::Messages->delete; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20866
:
75750
|
75784
|
75791
|
75813
|
75814