Bugzilla – Attachment 76017 Details for
Bug 20929
koha-dump should not pass a --password argument to mysqldump
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Use env variable instead of --password argument for mysqldump
patch.diff (text/plain), 1.41 KB, created by
Samir Shah
on 2018-06-13 08:31:29 UTC
(
hide
)
Description:
Use env variable instead of --password argument for mysqldump
Filename:
MIME Type:
Creator:
Samir Shah
Created:
2018-06-13 08:31:29 UTC
Size:
1.41 KB
patch
obsolete
>diff --git a/debian/scripts/koha-dump b/debian/scripts/koha-dump >index ff171a0..503de6b 100755 >--- a/debian/scripts/koha-dump >+++ b/debian/scripts/koha-dump >@@ -2,17 +2,17 @@ > # > # koha-dump: dump all contents and configs for a Koha site > # Copyright 2010 Catalyst IT, Ltd >-# >+# > # This program is free software: you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > # the Free Software Foundation, either version 3 of the License, or > # (at your option) any later version. >-# >+# > # This program is distributed in the hope that it will be useful, > # but WITHOUT ANY WARRANTY; without even the implied warranty of > # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > # GNU General Public License for more details. >-# >+# > # You should have received a copy of the GNU General Public License > # along with this program. If not, see <http://www.gnu.org/licenses/>. > >@@ -69,8 +69,8 @@ dump_instance() > [ -z "$backupdir" ] && backupdir="/var/spool/koha/$name" > dbdump="$backupdir/$name-$date.sql.gz" > [ "$quiet" = "no" ] && echo "* DB to $dbdump" >- mysqldump --databases --host="$mysqlhost" \ >- --user="$mysqluser" --password="$mysqlpass" "$mysqldb" | >+ MYSQL_PWD="$mysqlpass" mysqldump --databases --host="$mysqlhost" \ >+ --user="$mysqluser" "$mysqldb" | > gzip > "$dbdump" > chown "root:$name-koha" "$dbdump" > chmod g+r "$dbdump"
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20929
:
76017
|
76018
|
76019
|
79052
|
87356